feat: Add metadataIpfsHash to StakingViewer Pool struct - Githubissues

NexusMutual / smart-contracts

GNU General Public License v3.0

170 stars 62 forks source link

feat: Add metadataIpfsHash to StakingViewer Pool struct #1216

Closed rackstar closed 3 months ago

rackstar commented 3 months ago

Context

Add a new field metadataIpfsHash to StakingViewer Pool struct

Changes proposed in this pull request

Add a new field metadataIpfsHash to StakingViewer Pool struct
add missing view modifier to StakingProducts.getPoolMetadata
small lint fixes (spaces, modifier ordering)

Test plan

add unit test

Checklist

[x] Rebased the base branch
[ ] Attached corresponding Github issue
[x] Prefixed the name with the type of change (i.e. feat, chore, test)
[x] Performed a self-review of my own code
[x] Followed the style guidelines of this project
[ ] Made corresponding changes to the documentation
[x] Didn't generate new warnings
[x] Didn't generate failures on existing tests
[x] Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

:cake: = Nice to have but not essential.
:bulb: = Suggestion or a comment based on personal opinion
:hammer: = I believe this should be changed.
:thinking: = I don’t understand something, do you mind giving me more context?
:rocket: = Feedback