feat: StakingPool fixes + batch NXM withdrawals v2.8.0 - Githubissues

NexusMutual / smart-contracts

GNU General Public License v3.0

170 stars 62 forks source link

feat: StakingPool fixes + batch NXM withdrawals v2.8.0 #1231

Closed rackstar closed 2 months ago

rackstar commented 2 months ago

Context

https://github.com/NexusMutual/smart-contracts/issues/1198 https://github.com/NexusMutual/smart-contracts/issues/1184

Merging to master as these code has been released:

https://www.notion.so/nxmcommunity/Release-2-8-0-Staking-Pool-Fixes-Batch-Withdrawals-StakingViewer-f15e7b77eb44422883910ab12976d327

Changes proposed in this pull request

Protocol:

audit (Staking Pool Fixes + batch NXM withdrawal)
- audit changes summary
- final audit commit hash e62eed0
add metadataIpfsHash to StakingViewer.getPool

Scripts:

create2 script library linking
staking pool rewards fix
staking pool metadata migration
execute gov proposal fork test script
encode / decode gov proposal action data

Misc:

@nexusmutual/deplyoments upgrade to 2.8.0

Test plan

manual test
fork test
unit tests

Checklist

[x] Rebased the base branch
[x] Attached corresponding Github issue
[x] Prefixed the name with the type of change (i.e. feat, chore, test)
[x] Performed a self-review of my own code
[x] Followed the style guidelines of this project
[x] Made corresponding changes to the documentation
[x] Didn't generate new warnings
[x] Didn't generate failures on existing tests
[x] Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

:cake: = Nice to have but not essential.
:bulb: = Suggestion or a comment based on personal opinion
:hammer: = I believe this should be changed.
:thinking: = I don’t understand something, do you mind giving me more context?
:rocket: = Feedback