search

NexusSocial / nexus-vr

Social VR Game
Apache License 2.0
19 stars 6 forks source link

did-simple: fix bugs in decode related to overflow detection and test all possible varints #101

Closed TheButlah closed 4 months ago

TheButlah commented 4 months ago

As @lyuma pointed out in #100, we needed to check to make sure that no bits were truncated during the left shift. It was not sufficient to just rely on checked_shl for this.

TheButlah commented 4 months ago

Hmm, good point... I am not sure i consider that approach more intuitive but it would be slightly faster