search

NexusSocial / nexus-vr

Social VR Game
Apache License 2.0
19 stars 6 forks source link

did-simple: implement pubkey access with fixed size arrays #98

Closed TheButlah closed 4 months ago

TheButlah commented 4 months ago

Rebased on #100, merge that first.

I'm not sure about this PR. I may have overcomplicated things.

~~The goal was to make it so that the pubkey is always returned as a reference to a fixed-size array. This is because key algos specify up front their length, so we want to show that we validated that length. However, I'm not sure that the type machinery I made is user friendly. What are your thoughts @kayhhh @MalekiRe @Schmarni-Dev?~~

TheButlah commented 4 months ago

After getting feedback from @kayhhh that the api looks unecessarily complicated, I've dumbed it down and gotten rid of the fixed size arrays.