NgLixuanNixon / pe

0 stars 0 forks source link

Null can be added as a genre and pops out when you find for genre "null" #4

Open NgLixuanNixon opened 10 months ago

NgLixuanNixon commented 10 months ago

I am able to add in a genre called null and it appears when i search null

but when the genre is set automatically to null it does not show up

image.png

nus-se-script commented 9 months ago

Team's Response

Great catch. However in our opinion we think this is a lower severity than medium.

To explain, the purpose of entering list /g null would be to look for resources with NO genre at all. Meaning, the resource was classified as having no genre at all by the librarian when they were using the add command. This means they did not even specify the "/g " argument for the add command.

When you perform list /g null, our program checks if the resource has no genre or a genre. If no genre at all, then it will fit the "/g null" filter criteria and be listed. When you add the null genre purposely, this means the resource actually does have a genre, its just called "null".

However, we do acknowledge that a warning or some kind of information could be provided regarding what "null" means in the list.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]