search

NgYaoDong / pe

1 stars 0 forks source link

Bug for displaying wrong cost #5

Open NgYaoDong opened 2 months ago

NgYaoDong commented 2 months ago

Feature Flaw (Severity MEDIUM)

Steps to reproduce

  1. Input e/ add/ d/ spider-man tickets t/ movie amt/ 9999999.30 date/ 29.02.2024
  2. Input e/ list/

Expected

`Current Expenses:

  1. shopping | NA | Cost: $128.00 | date: 31.03.2024
  2. spider-man tickets | MOVIE | Cost: $13.50 | date: 12.02.2024
  3. spider-man tickets | MOVIE | Cost: $9999999.30 | date: 29.02.2024 Total expenses: $10000140.80`

Actual

`Current Expenses:

  1. shopping | NA | Cost: $128.00 | date: 31.03.2024
  2. spider-man tickets | MOVIE | Cost: $13.50 | date: 12.02.2024
  3. spider-man tickets | MOVIE | Cost: $9999999.00 | date: 29.02.2024 Total expenses: $10000140.00`

image.png

soc-se-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Bug for adding cost

Functionality Bug (Severity MEDIUM)

Steps to reproduce

  1. Input e/ add/ d/ spider-man tickets t/ movie amt/ 9999999.50 date/ 29.02.2024

Expected

Expenditure added successfully.

Actual

Invalid amount format! Please ensure the amount has at most two decimal places.

The amount I had entered was less than the amount they stated in the product, which they stated: Please enter an amount less than or equal to 9999999.99.

image.png

[original: nus-cs2113-AY2324S2/pe-interim#2209] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

A flaw that causes occasional inconvenience to some users but they can continue to use the product. 9999999.50 is a rare expenditure for the target user(university students) of app. this is pushing to edge cases, it seems high input decimal values affect the saved value and hence the total amount is affected also.

As it is a very rare occurrence to have such higher input amounts for university students we, propose a low severity instead as it causes minor inconvenience in rare cases

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]