NginxProxyManager / nginx-proxy-manager

Docker container for managing Nginx proxy hosts with a simple, powerful interface
https://nginxproxymanager.com
MIT License
23.43k stars 2.72k forks source link

Edit DNS challenge credentials #1316

Open internetfreak opened 3 years ago

internetfreak commented 3 years ago

Is your feature request related to a problem? Please describe. Currently, when creating (wildcard) certificates there's no easy way to edit the credentials used as they are stored internally. If e.g. we need to update a password, we must also update it for NPM or the renewal will fail. Only way to easily update it would be to request a new certificate with the updated credentials and set that new certificate for all affected hosts before deleting the old one.

Describe the solution you'd like Offer a possibility to edit credentials without having to delete and re-add the certificate

Describe alternatives you've considered I know we could map the folder where the credentials are stored via docker volumes or use docker execute but that is not really comfortable. Also, in the case you have multiple users accessing their own hosts and certs you would need to grant everyone access to the server via ssh (and possibly root/sudo access depending on how you run the docker container) which is not always feasible from a security point.

Additional context Nothing

chaptergy commented 3 years ago

Edit: what I said is totally wrong, I got things mixed up, just ignore this comment.

~It should work to update the credentials and force-renew the certificate. This should update the credetials on file without having to delete the certificate and request a new one.~

internetfreak commented 3 years ago

But where can I update the credentials? Via docker volumes/docker execute? If I choose to renew a certificate, from which I know it should still have the old credentials, nothing happens

chaptergy commented 3 years ago

Oh, sorry, I mixed up the interface for the host and certificate.

github-actions[bot] commented 9 months ago

Issue is now considered stale. If you want to keep it open, please comment :+1: