NPM Stops working properly if Streamed container is down.

[Frenzoid]

Checklist

• Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
  • Yes

• Are you sure you're not using someone else's docker image?

  • Yes

• Have you searched for similar issues (both open and closed)?

  • Yes

Describe the bug When a Streamed container is stopped, the npm container enter a configuration loading loop, proxy hosts and everything else stops working.

Nginx Proxy Manager Version

To Reproduce Steps to reproduce the behavior: 1) Create a new container that requires streaming ( for example, a Minecraft server ) 2) Create a new Stream on the NPM Panel. 3) Stop the streamed container without first disabling the Stream.

Expected behavior The NPM container keeps working normaly. Same as when a Proxy Host container is stopped.

Screenshots logs of the NPM container after I stop my MC container.

Operating System

Additional context

[Purrrpley]

I think a way to fix this is to do what the proxy hosts do and use proxy_pass $server; instead of proxy_pass server;. So instead of:

proxy_pass <server>;

You'd have:

set $server = "<server>";
proxy_pass = $server;

... I'm not sure why Nginx works this way, but it does, and that fixes it (for me anyway). So I think changing how NPM auto-generates files to do that for stream hosts too would solve this issue.

You can workaround this though by manually modifying /data/nginx/streams/*.conf yourself, but that breaks if you make a change in the GUI and the file gets regenerated :/

edit: this seems to actually break the streaming part for some reason (even though the NPM control panel shows "online"), so this actually doesn't fix it (or at least the workaround doesn't), but doing this does prevent it from getting stuck in an error loop at startup...

[github-actions[bot]]

Issue is now considered stale. If you want to keep it open, please comment :+1: