NginxProxyManager / nginx-proxy-manager

Docker container for managing Nginx proxy hosts with a simple, powerful interface
https://nginxproxymanager.com
MIT License
20.7k stars 2.4k forks source link

Unable to disable http2 #264

Open hashimea opened 4 years ago

hashimea commented 4 years ago

Checklist

Describe the bug

Unable to disable http2 after enabling it for a host conf. I checked the http2_enabled value in the database and it is 0. but still the configuration generated with http2 when saving (without http2 selection)

v2.0.14

To Reproduce Steps to reproduce the behavior:

  1. Add 2-3 host configuration with letsencrypt ssl
  2. enable http2 for any of the configuration
  3. disable the http2 configuration of that host
  4. See error - Still http2 is generated for that configuration

Expected behavior not adding http2 to the configuration when database http2_enabled value is 0

Screenshots If applicable, add screenshots to help explain your problem.

Operating System ubuntu 19 + docker

miguelwill commented 4 years ago

grep listen *.conf : 70.conf:listen 443 ssl http2; 71.conf: listen 80; 72.conf: listen 80; 72.conf:listen 443 ssl http2; 73.conf: listen 80; 74.conf: listen 80; 74.conf:listen 443 ssl http2; 7.conf: listen 80; 8.conf: listen 80; 8.conf:listen 443 ssl http2; 9.conf: listen 80;

as you can see, the http2 enablement filter defined in the template is not being applied correctly, and http2 is enabled when the host is created

hashimea commented 4 years ago

@miguelwill http2 is a server-wide port-based configuration. So i think it will be better to take it out from single hosts to some global setting

ghost commented 1 year ago

@miguelwill http2 is a server-wide port-based configuration. So i think it will be better to take it out from single hosts to some global setting

Where / how do i disable http2 globally then? i have the same issue

ghost commented 1 year ago

i remote connected into my NPM virtual machine and navigated to the location where my config files are for each proxy host; cd data/nginx/proxy_host then manually edited each of the configs in that location to remove the text "https2" from each entry. i also disabled every example of https2 on switch in the GUI.

im not sure how to apply these changes other than just saving the config file and restarting the VM. this has 'saved' the changes within each of the files however the issues im facing casued by enabled https2 is still present.

ghost commented 1 year ago

@miguelwill http2 is a server-wide port-based configuration. So i think it will be better to take it out from single hosts to some global setting

returning to this as its still an issue for me - where and how do we do make this change? could you explain a little more?

FroggMaster commented 1 year ago

I'd like some more information on how to disable HTTP2 globally as well.

I'm currently encounter some problems with NGINX/HTTP2 and the easiest solution is to globally disable it but I'm not entirely certain how to do this with NPM.

github-actions[bot] commented 2 months ago

Issue is now considered stale. If you want to keep it open, please comment :+1: