search

NginxProxyManager / nginx-proxy-manager

Docker container for managing Nginx proxy hosts with a simple, powerful interface
https://nginxproxymanager.com
MIT License
22.95k stars 2.66k forks source link

Support docker secrets in DNS Challenge configs #3128

Open alaricljs opened 1 year ago

alaricljs commented 1 year ago

Is your feature request related to a problem? Please describe.

It's annoying to pull up my Cloudflare token every time I need to instantiate a new cert.

Describe the solution you'd like

It would be great if docker secrets could be used in place of manually entering the token. Ideally there would be support for multiple secrets but also multiple certificates could use the same secret. This would also allow for updating the token/secret without redoing the cert config in NPM.

The addition of *_secret=/run/secrets/... or similar within the challenge config makes for the least UI intensive implementation. Alternatively enumerating all ENV vars containing '/run/secrets/' for a drop-down UI style might be well received.

Describe alternatives you've considered

Nothing

Additional context

You alreayd have support for some runtime config via secrets, so I think this should be straight forward to implement.

github-actions[bot] commented 7 months ago

Issue is now considered stale. If you want to keep it open, please comment :+1: