search

NginxProxyManager / nginx-proxy-manager

Docker container for managing Nginx proxy hosts with a simple, powerful interface
https://nginxproxymanager.com
MIT License
22.67k stars 2.64k forks source link

Use a newer version of Tabler UI (so Bootstrap 5) #3133

Open TheDogHusky opened 1 year ago

TheDogHusky commented 1 year ago

Is your feature request related to a problem? Please describe.

No

Describe the solution you'd like

Make an update to use latest Tabler version (which uses bootstrap 5). Right now Nginx Proxy Manager uses an old version of tabler and bootstrap 4. For a more modern and beautiful UI with no problems, i would suggest to use a newer version of Tabler. (This is purely to make the UI look even better than it actually look, this isnt very urgent)

Describe alternatives you've considered

No alternatives.

Additional context

Newer versions of Tabler uses Bootstrap 5.

extragreen commented 9 months ago

This would also address a few vulnerabilities associated with bootstrap 4:

CVE-2018-14041 CVE-2019-8331 CVE-2018-14040 CVE-2018-14042

However, I haven't determined whether npm specifically is vulnerable to these based on the bootstrap components it uses

TheDogHusky commented 9 months ago

But I guess we'll have to wait a lot as they have 1.2k issues and almost never answer :')

drwetter commented 7 months ago

Looking at its age, the bootstrap version is going already to primary school: https://github.com/twbs/bootstrap/releases/tag/v4.0.0 .

NIST doesn't list the proxy manager as vulnerable though. Assuming they didn't get it as the vendor or someone else has to notify NIST.