Open devedse opened 1 year ago
I can confirm this. Sometimes it pretty annyoing
Any workaround at least? 3-4 minutes downtime just to restart npm is a lot, and very annoying when changing configs and have to restart to see the results.
I guess you could map a volume to the root fs that persists the /opt folder
I guess you could map a volume to the root fs that persists the /opt folder
Thanks, it worked!
I've ran into the exact same issue at startup of the docker container where the chown command (Setting Ownership) took around 25 minutes to complete and this happens every time I turn the container on.
I guess you could map a volume to the root fs that persists the /opt folder
Thanks, it worked!
How? can you please explain? I am not getting pass to the settings ownership and it simply timesout in my case. I am mounting the data and letsencrypt folder on an nfs share.
I too am hitting this issue on my TrueNAS system. How I resolve this for now.
Step 1: Create a PVC mount called /opt/certbot2 (ie. an external mount is managed by TrueNAS - this is not the same as a named mount managed by docker, from docker's perspective it's still a host mount, but it's as good as you get with truenas). Step 2: Start the container, then log into it via. shell (use heavyscript or truenas to get into the shell) Step 3: Copy everything in /opt/certbot to /opt/certbot2 (cp -a /opt/certbot/* /opt/certbot2) Step 4: Stop the container and change the PVC mount from /opt/certbot2 to /opt/certbot Step 5: Start the container again.
It should now be very quick to chown, because the storage is external, not copy on write. Of course, this is a terrible solution, because we are now overriding the docker image for what is in /opt/certbot, so as the container updates, our /opt/certbot will not unless you remove the PVC and do the above steps again.
I guess you could map a volume to the root fs that persists the /opt folder
Thanks, it worked!
@panos-stavrianos
How did you do that? I'm having the same problem running on my server, when I run it on my machine it doesn't take long. 😢
I would guess,
run the container and wait for it to start, use docker copy and copy the /opt from the container to a folder on your harddisk once this is done, stop the container add a volume that maps the copy on your local disk to the /opt inside the container start the container again
Am Mo., 19. Feb. 2024 um 18:45 Uhr schrieb Lapo @.***>:
I guess you could map a volume to the root fs that persists the /opt folder
Thanks, it worked!
@panos-stavrianos https://github.com/panos-stavrianos
How did you do that? I'm having the same problem running on my server, when I run it on my machine it doesn't take long.
— Reply to this email directly, view it on GitHub https://github.com/NginxProxyManager/nginx-proxy-manager/issues/3154#issuecomment-1952944043, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY6MDHQYN3XKWID27OJX3LYUOFSHAVCNFSM6AAAAAA34FODYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSHE2DIMBUGM . You are receiving this because you commented.Message ID: @.***>
I would guess, run the container and wait for it to start, use docker copy and copy the /opt from the container to a folder on your harddisk once this is done, stop the container add a volume that maps the copy on your local disk to the /opt inside the container start the container again Am Mo., 19. Feb. 2024 um 18:45 Uhr schrieb Lapo @.>: … I guess you could map a volume to the root fs that persists the /opt folder Thanks, it worked! @panos-stavrianos https://github.com/panos-stavrianos How did you do that? I'm having the same problem running on my server, when I run it on my machine it doesn't take long. — Reply to this email directly, view it on GitHub <#3154 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY6MDHQYN3XKWID27OJX3LYUOFSHAVCNFSM6AAAAAA34FODYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSHE2DIMBUGM . You are receiving this because you commented.Message ID: @.>
@Nightreaver
Thank you!! it worked :)
I'm having the same problem with 2.11.1 via the TrueNAS catalog chart version 1.0.27
I never seem to get past the chown before TrueNAS decides that the container is unhealthy and attempts to restart it, causing an endless loop
2024-02-25 09:32:46.464991-05:00[1;34m❯ [1;36mConfiguring npm user ...[0m
2024-02-25 09:36:39.192117-05:00[1;34m❯ [1;36mConfiguring npm group ...[0m
2024-02-25 09:36:51.272227-05:00[1;34m❯ [1;36mChecking paths ...[0m
2024-02-25 09:37:09.147531-05:00[1;34m❯ [1;36mSetting ownership ...[0m
2024-02-25 09:58:04.848091-05:00[1;34m❯ [1;36mConfiguring npm user ...[0m
I haven't tried the proposed workaround
EDIT
I was just in the console when the container was restarted and it echoed the following message to the console:
command terminated with exit code 137
Affected by this issue as well on TrueNAS SCALE 23.10.2. Same issue on the community train and installing the docker image directly as well. Takes about 10 minutes for mine to fully load.
I too am hitting this issue on my TrueNAS system. How I resolve this for now.
Step 1: Create a PVC mount called /opt/certbot2 (ie. an external mount is managed by TrueNAS - this is not the same as a named mount managed by docker, from docker's perspective it's still a host mount, but it's as good as you get with truenas). Step 2: Start the container, then log into it via. shell (use heavyscript or truenas to get into the shell) Step 3: Copy everything in /opt/certbot to /opt/certbot2 (cp -a /opt/certbot/* /opt/certbot2) Step 4: Stop the container and change the PVC mount from /opt/certbot2 to /opt/certbot Step 5: Start the container again.
It should now be very quick to chown, because the storage is external, not copy on write. Of course, this is a terrible solution, because we are now overriding the docker image for what is in /opt/certbot, so as the container updates, our /opt/certbot will not unless you remove the PVC and do the above steps again.
So I copied the files to my HDD pool in my /data
mount that mounts to npm and created a folder there called certbot
and mounted a host path of /opt/certbot
to /data/certbot
it has the same effect. Boots in seconds now.
So I copied the files to my HDD pool in my
/data
mount that mounts to npm and created a folder there calledcertbot
and mounted a host path of/opt/certbot
to/data/certbot
it has the same effect. Boots in second now.
This actually really helped me out. Working in Portainer, I just edited my stack compose.
First added the following
volumes:
- ./data/opt:/opt/certbot-cp # command will generate the /certbot folder in /data/opt
command: 'cp -avr /opt/certbot /opt/certbot-cp'
waited for the app to output the command response (a ton of lines starting with '/opt/certbot then changed to
volumes:
- ./data/opt/certbot:/opt/certbot # added /certbot to host path, removed -cp from container path
# removed command setting
and restarted. npm loaded pretty much immediately, and I was able to access the admin panel. restarted again just to make sure, and npm loaded in less than 10 seconds.
I'm still learning docker so I may not be doing it the best way, but it worked for me.
So I copied the files to my HDD pool in my
/data
mount that mounts to npm and created a folder there calledcertbot
and mounted a host path of/opt/certbot
to/data/certbot
it has the same effect. Boots in second now.This actually really helped me out. Working in Portainer, I just edited my stack compose.
First added the following
volumes: - ./data/opt:/opt/certbot-cp # command will generate the /certbot folder in /data/opt command: 'cp -avr /opt/certbot /opt/certbot-cp'
waited for the app to output the command response (a ton of lines starting with '/opt/certbot then changed to
volumes: - ./data/opt/certbot:/opt/certbot # added /certbot to host path, removed -cp from container path # removed command setting
and restarted. npm loaded pretty much immediately, and I was able to access the admin panel. restarted again just to make sure, and npm loaded in less than 10 seconds.
I'm still learning docker so I may not be doing it the best way, but it worked for me.
Yep, same thing I did, just using docker compose.
I too am hitting this issue on my TrueNAS system. How I resolve this for now. Step 1: Create a PVC mount called /opt/certbot2 (ie. an external mount is managed by TrueNAS - this is not the same as a named mount managed by docker, from docker's perspective it's still a host mount, but it's as good as you get with truenas). Step 2: Start the container, then log into it via. shell (use heavyscript or truenas to get into the shell) Step 3: Copy everything in /opt/certbot to /opt/certbot2 (cp -a /opt/certbot/* /opt/certbot2) Step 4: Stop the container and change the PVC mount from /opt/certbot2 to /opt/certbot Step 5: Start the container again. It should now be very quick to chown, because the storage is external, not copy on write. Of course, this is a terrible solution, because we are now overriding the docker image for what is in /opt/certbot, so as the container updates, our /opt/certbot will not unless you remove the PVC and do the above steps again.
So I copied the files to my HDD pool in my
/data
mount that mounts to npm and created a folder there calledcertbot
and mounted a host path of/opt/certbot
to/data/certbot
it has the same effect. Boots in seconds now.
This cant be an solution, only an workaround. Its VERY anoying...at every update of the container or helm forces an downtime for over an hour...
I too am hitting this issue on my TrueNAS system. How I resolve this for now. Step 1: Create a PVC mount called /opt/certbot2 (ie. an external mount is managed by TrueNAS - this is not the same as a named mount managed by docker, from docker's perspective it's still a host mount, but it's as good as you get with truenas). Step 2: Start the container, then log into it via. shell (use heavyscript or truenas to get into the shell) Step 3: Copy everything in /opt/certbot to /opt/certbot2 (cp -a /opt/certbot/* /opt/certbot2) Step 4: Stop the container and change the PVC mount from /opt/certbot2 to /opt/certbot Step 5: Start the container again. It should now be very quick to chown, because the storage is external, not copy on write. Of course, this is a terrible solution, because we are now overriding the docker image for what is in /opt/certbot, so as the container updates, our /opt/certbot will not unless you remove the PVC and do the above steps again.
So I copied the files to my HDD pool in my
/data
mount that mounts to npm and created a folder there calledcertbot
and mounted a host path of/opt/certbot
to/data/certbot
it has the same effect. Boots in seconds now.This cant be an solution, only an workaround. Its VERY anoying...at every update of the container or helm forces an downtime for over an hour...
Not a solution, just a workaround for now.
I too am hitting this issue on my TrueNAS system. How I resolve this for now. Step 1: Create a PVC mount called /opt/certbot2 (ie. an external mount is managed by TrueNAS - this is not the same as a named mount managed by docker, from docker's perspective it's still a host mount, but it's as good as you get with truenas). Step 2: Start the container, then log into it via. shell (use heavyscript or truenas to get into the shell) Step 3: Copy everything in /opt/certbot to /opt/certbot2 (cp -a /opt/certbot/* /opt/certbot2) Step 4: Stop the container and change the PVC mount from /opt/certbot2 to /opt/certbot Step 5: Start the container again. It should now be very quick to chown, because the storage is external, not copy on write. Of course, this is a terrible solution, because we are now overriding the docker image for what is in /opt/certbot, so as the container updates, our /opt/certbot will not unless you remove the PVC and do the above steps again.
So I copied the files to my HDD pool in my
/data
mount that mounts to npm and created a folder there calledcertbot
and mounted a host path of/opt/certbot
to/data/certbot
it has the same effect. Boots in seconds now.This cant be an solution, only an workaround. Its VERY anoying...at every update of the container or helm forces an downtime for over an hour...
Not a solution, just a workaround for now.
Ok, sorry if my comment was a bit salty...lets be productive: Is there an elegant solution for this? What about executing chrown only if PUID/PGID is set or check if the first file under "/data/certbot" has the right permissions and owner and then skip it?
Did anybody ever figure out an answer to the original question of why this is required? Could we simply...remove the offending line?....
Same issue here unfortunately
Same here, Truenas 24.10-Beta.1.
10 to 15 minutes downtime, on an SSD array. I can imagine how frustrating it must be on a pure HDD array.
I think instead of using a hacky workaround, perhaps the underlying issue with whatever causes certbot to complain about can be resolved? Like, if it's to make it not complain about not running as root... isn't there something with the python stuff that lets user packages to be used?
Maybe I'm just dumb but I'm baffled why this is a thing...
Workaround add an Additional Environment Variable on Truenas 24.10-Beta.1:
S6_STAGE2_HOOK=sed -i $d /etc/s6-overlay/s6-rc.d/prepare/30-ownership.sh
Workaround add an Additional Environment Variable on Truenas 24.10-Beta.1:
S6_STAGE2_HOOK=sed -i $d /etc/s6-overlay/s6-rc.d/prepare/30-ownership.sh
That's indeed the current (sometime buggy) workaround, but that won't resolve the issue itself.
The issue was caused by going from a python user package to a system package (see commit linked in the issue), which, if I understand it well, can only be run as root unless you chown it back, which take ages.
The question is, should we really chown the whole /opt/certbot
, or is it possible to do it another way, like chowning only a subset (like only the plugin directory, and only if there is a plugin installed) to reduce the time required, or, ideally, finding a better solution that the commit introducing this was trying to address.
It's only 20 minutes startup time with HDD in a truenas array. WIth the fix, the startup time is 5 seconds.
This happens on straight docker as well on zfs.
Wow, this is annoying. I just installed it on my TrueNAS 24.10 and while I was searching for a solution and writing this text it is still setting ownershop.
I fixed it by setting UID and GID to 0
because everything in /opt/certbot
belongs to root:root
anyway.
Wow, this is annoying. I just installed it on my TrueNAS 24.10 and while I was searching for a solution and writing this text it is still setting ownershop. I fixed it by setting UID and GID to
0
because everything in/opt/certbot
belongs toroot:root
anyway.
I experienced the same issue, thank you for your solution!
Wow, this is annoying. I just installed it on my TrueNAS 24.10 and while I was searching for a solution and writing this text it is still setting ownershop. I fixed it by setting UID and GID to
0
because everything in/opt/certbot
belongs toroot:root
anyway.
Thank you! Finally, it starts up.
Checklist
jc21/nginx-proxy-manager:latest
docker image?Describe the bug
When I start the container for the first time it's taking an incredibly long due to it setting ownership:
I did a bit of investigation and found out it's due to this command:
This code was added in this commit: https://github.com/NginxProxyManager/nginx-proxy-manager/commit/05307aa253c073cf94237fc96d816ec2919f4d7f
I ran this command myself inside the container and it took about 5 minutes to complete:
To me it feels a bit strange to have to execute this command on the /opt folder which isn't even mapped to my host system. So why not do this during the creation of the container rather then during boot?
Nginx Proxy Manager Version
2.10.4
To Reproduce See above
Expected behavior
Boot quickly
Screenshots
N/A
Operating System
Docker inside a container on a Synology NAS
Additional context