Tries to renew already "deleted" certificates

[Mainfrezzer]

Checklist

• Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
  • Yes
• Are you sure you're not using someone else's docker image?
  • Yes
• Have you searched for similar issues (both open and closed)?
  • Yes

Describe the bug

The container tries to renew two certificates which i deleted a while ago from the GUI but apparently didnt get gemoved at all. Those certs are no longer in use and NPM keeps logging the following errors.

Nginx Proxy Manager Version

v2.10.4

To Reproduce

Probably a bit hazy, since the certs were old. i cant remember on which version i created them with but what i ultimately did was Steps to reproduce the behavior:

1. Delete the Certs, that i no longer use, via the GUI
2. Created new Certs
3. Applied the new certs to the existing proxy rules
4. See error (after a while i guess since it checks for the renewal window)

Expected behavior

Well, i would expect any entry related to the old certs to be banished into oblivion

Screenshots

(the manual renewal in the screenshot was before i noticed that it tries to renew the "no longer existing but apparently zombie certs". Wanted to check what was wrong with it but that worked fine)

deleting the affected npm-X.conf in letsencrypt/renewal did solve the "issue" but since the delete button certainly didnt delete anything apart from the certs appearing in the gui, it doesnt do its job xD

[github-actions[bot]]

Issue is now considered stale. If you want to keep it open, please comment :+1:

[etfz]

As far as I can tell, one possible cause for this is that the delete functions attempts to delete the certificate by using the certbot revoke command, which will fail if the certificate has already expired.

https://github.com/NginxProxyManager/nginx-proxy-manager/blob/develop/backend/internal/certificate.js#L1029