NginxProxyManager / nginx-proxy-manager

Docker container for managing Nginx proxy hosts with a simple, powerful interface
https://nginxproxymanager.com
MIT License
22.89k stars 2.66k forks source link

NPM and webmin #3431

Open tokar86a opened 10 months ago

tokar86a commented 10 months ago

Hi

I am running Webmin behind NPM. The problem i am having is that when i am visiting Webmin admin portal i get the same loggin ip as the NPM docker contatiner host. In this case 192.168.1.118 when the ip should be 192.168.1.160.

Any suggesting when it comes to get webmin to understand my true IP address?

I have sett the following headers in NPM advance section:

real_ip_header CF-Connecting-IP; proxy_set_header Host $host; proxy_set_header X-Real-IP $remote_addr; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;

And in Webmin i have turn the following setting on: Trust remote IP address provided by proxies.

Can i somehow add another proxy_set_header ??

ale82x commented 10 months ago

i used this solution

create proxy host with classic domain webmin.domain.tld scheme https ip x.x.x.x port 10000

on webmin / virtualmin

nano /etc/webmin/config add at end referers=webmin.domain.tld

nano /etc/webmin/miniserv.conf add at end redirect_ssl=1 redirect_host=webmin.domain.tld

systemctl restart webmin

works, also file manager

tokar86a commented 10 months ago

i used this solution

create proxy host with classic domain webmin.domain.tld scheme https ip x.x.x.x port 10000

on webmin / virtualmin

nano /etc/webmin/config add at end referers=webmin.domain.tld

nano /etc/webmin/miniserv.conf add at end redirect_ssl=1 redirect_host=webmin.domain.tld

systemctl restart webmin

works, also file manager

I have try that thing to and i also is giving me the same IP address of 192.168.1.118 when it shold end whit 160.

ale82x commented 10 months ago

yes i use that config because webmin is behind NAT , so with npm i don't need to port forwarding...

but i always redirect to webmin.domain.tld

tokar86a commented 10 months ago

yes i use that config because webmin is behind NAT , so with npm i don't need to port forwarding...

but i always redirect to webmin.domain.tld

So you also getting the IP of the NPM docker host then?

My question here is how i can get webmin to see the real IP of the person that are signing in or try to sign in.

ale82x commented 10 months ago

i have webmin behind NAT, and instead port forwarding i use npm to expose wemin...

yes i check by see npm ip not real ip...

i try to use https://github.com/webmin/webmin/issues/1027#issuecomment-1507807131

but file manager won't work...

if you have a better solution i will try

thank you

tokar86a commented 10 months ago

i have webmin behind NAT, and instead port forwarding i use npm to expose wemin...

yes i check by see npm ip not real ip...

i try to use webmin/webmin#1027 (comment)

but file manager won't work...

if you have a better solution i will try

thank you

I dont use the option that you have done in the miniserv.conf and config files to expose the webmin interface. I have only created a domain inside NPM and made it forwarding everything from webmin.example.com -> 192.168.1.146:10000

And that is working beside the problem whit the IP address don't seems to be recorded right.

ale82x commented 9 months ago

i think to have real ip is port forwarding (that use layer 3 TCP, instead nginx-pm use layer 7 application HTTP) and webmin can't "read" header X-Real-IP such as apache / nginx

tokar86a commented 9 months ago

i think to have real ip is port forwarding (that use layer 3 TCP, instead nginx-pm use layer 7 application HTTP) and webmin can't "read" header X-Real-IP such as apache / nginx

The strange thing is that maybe more people should be reported about this if that was the case? Webmin staff seems to not be aware about any problem here.

github-actions[bot] commented 3 months ago

Issue is now considered stale. If you want to keep it open, please comment :+1:

tokar86a commented 3 months ago

Have still not been able to figure this out.