NginxProxyManager / nginx-proxy-manager

Docker container for managing Nginx proxy hosts with a simple, powerful interface
https://nginxproxymanager.com
MIT License
23.45k stars 2.72k forks source link

Access List modal - Authorization tab - autopopulates login credentials #3613

Open Nedevski opened 9 months ago

Nedevski commented 9 months ago

Checklist

Describe the bug

When trying to edit IPs in the Access List tab, the Authorization tab gets autopopulated with the login credentials. This occurs even when you don't open the Authorization tab. As a result of that, your Nginx Proxy Manager credentials get saved as Access List user/pass. Because of that, every time you change/add an IP, you have to go in the tab and auto-clear the credentials, otherwise they get saved.

Nginx Proxy Manager Version

v2.11.1

To Reproduce Steps to reproduce the behavior:

  1. Have your login user/pass saved in Chrome
  2. Go to Access Lists
  3. Add or Edit and existing access list.
  4. Navigate to the Authorization tab to confirm that the user/pass gets autopopulated
  5. If adding - add a single IP, if editing - just click save.
  6. Observe that your user has been saved in the access list.

Expected behavior

The fields should not get autopopulated

Screenshots

Screenshot 2024-03-08 102936

Operating System

Ubuntu + Docker

Additional context

Chrome 122.0.6261.112

bluekitedreamer commented 8 months ago

This one is a difficult one to solve, the chrome autofill is a "moving target" with regards to it's implementation and compliance of it's own implementation. Everything from the autocomplete to prevent_autofill directives have been observed and then ignored in the past. Some workarounds in the code lead to security vulnerabilities, for example not marking as the password field would unmask the field.

Yet, still, this page doesn't appear to have any exists "blocks" to the autofill functionality.

Easiest workaround it to disable autofill for the page...

Nedevski commented 8 months ago

Yes, but this workaround will prevent me from having my login details autofilled on the login page, which is also not ideal for me, as I have a couple of different instances that I manage. :(

bluekitedreamer commented 8 months ago

workaround - A [procedure] or a temporary fix that [bypasses] a problem and allows the [user] to continue working until a better solution can be provided

Don't like the answer, don't use it...

bluekitedreamer commented 8 months ago

Just load the different instances into profiles and keep them logged in if you have to switch back/forth that often

github-actions[bot] commented 1 month ago

Issue is now considered stale. If you want to keep it open, please comment :+1: