Duplicate advanced_config to both top and bottom

NginxProxyManager / nginx-proxy-manager

Docker container for managing Nginx proxy hosts with a simple, powerful interface

https://nginxproxymanager.com

MIT License

22.61k stars 2.63k forks source link

Duplicate advanced_config to both top and bottom #4098

Closed whc2001 closed 6 hours ago

whc2001 commented 7 hours ago

Trying to mitigate #3729 which caused #586 #1003 #2712 #2804 #3277 #3678 #3980 #3981 #4011

nginxproxymanagerci[bot] commented 7 hours ago

Docker Image for build 1 is available on DockerHub as nginxproxymanager/nginx-proxy-manager-dev:pr-4098

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes Note: this is a different docker image namespace than the official image

whc2001 commented 7 hours ago

Actually, this does not work. No matter the statement proxy_set_header Host $http_host; appears in the beginning or the end, if proxy_set_header Host $host; exists it would not lead to the intended behaviour. Some more code will be needed to correct this behaviour