search

NginxProxyManager / nginx-proxy-manager

Docker container for managing Nginx proxy hosts with a simple, powerful interface
https://nginxproxymanager.com
MIT License
23.32k stars 2.7k forks source link

http2 directive migration #4106

Closed dreik closed 1 month ago

dreik commented 1 month ago

reducing noise in logs

N.B. to reduce the noise for existing hosts you'll have to edit every single host with http2 enabled and simply press save.

jc21 commented 1 month ago

See #4075 this is already attempted, though is still WIP which is why I haven't looked at it too deeply

dreik commented 1 month ago

@jc21 sorry i've missed the PR you've mentioned as I've simply tried to fix the issues for myself. Meanwhile I've just checked all the comments left by @vladwing and proud to say that my PR already covered everything mentioned there.

vladwing commented 1 month ago

@jc21 you decide which one to accept, but this looks ready to me

nginxproxymanagerci[bot] commented 1 month ago

Docker Image for build 3 is available on DockerHub as nginxproxymanager/nginx-proxy-manager-dev:pr-4106

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes Note: this is a different docker image namespace than the official image

jc21 commented 1 month ago

Looks good to me