Improve test coverage - Githubissues

NginxProxyManager / nginx-proxy-manager

Docker container for managing Nginx proxy hosts with a simple, powerful interface

https://nginxproxymanager.com

MIT License

23.27k stars 2.7k forks source link

Improve test coverage #4125

Open snordmann opened 3 weeks ago

snordmann commented 3 weeks ago

In this PR my goal is to test more endpoints and maybe even the frontend. This should make verification of future changes easier.

snordmann commented 3 weeks ago

One thing that I noticed relating to the tests: The GET response for /api/proxy-hosts schema does not verify. The certificate property is not set on the returned proxy-hosts.

How should this be fixed? I see two options:

(a) Edit the schema to make certificate an optional property
(b) Adjust the backend to always include the certificate property