NginxProxyManager / nginx-proxy-manager

Docker container for managing Nginx proxy hosts with a simple, powerful interface
https://nginxproxymanager.com
MIT License
23.32k stars 2.7k forks source link

Edit User doesn't enforce email formatted emails, login does #4168

Open jonfriesen opened 1 week ago

jonfriesen commented 1 week ago

Checklist

Describe the bug

Email formatted content is not required in the Edit User email input field. This means a user can enter a non-email value (for example, just their name). However, the login page does enforce an email formatted value blocking the user from logging in.

Nginx Proxy Manager Version

v2.12.1

To Reproduce

  1. Login
  2. Edit the users email to be a non-email, for example joe
  3. Logout
  4. Try to login

Note: if you find yourself in this situation, in a chrome browser right click and inspect the email field on the login page, then edit the type="email" attribute on the email form to be type="text" and login.

Expected behavior

I think there are two directions here:

  1. Update the login key to be any value (not email specific)
  2. Enforce the email format in the Edit User page

Either are acceptable IMO.

Screenshots

image image

Operating System

TrueNAS Scale 24.10 deployed with Docker, using the community chart.

Additional context