Add Brotli Support - Githubissues

NginxProxyManager / nginx-proxy-manager

Docker container for managing Nginx proxy hosts with a simple, powerful interface

https://nginxproxymanager.com

MIT License

22.35k stars 2.59k forks source link

Add Brotli Support #713

Open arlllk opened 3 years ago

arlllk commented 3 years ago

Add the capability to use Brotli in the reverse proxy as a compression option. The official nginx module repository is currently active

hitchhooker commented 3 years ago

Has anybody come up with a fork or workaround to add brotli?

jc21 commented 3 years ago

Notes for anyone considering adding this:

The base docker image uses OpenResty and exists in this project and extensions are defined here. You'll need to open a PR there for this first
The UI should to have a switch to enable Compression and then select between gzip and brotli (if I understand this correctly)
This compression setting would need to be stored in the database and would require a new migration file
The proxy host nginx template exists here and would need to know about the compression choice.

xrh0905 commented 1 year ago

Member

Hi. I'm currently trying to work on it, but I'm new to these. So,from what I can tell, Brotli support needs to be added upstream, which I opened a PR for that. However, I'm not good at databases nor at frontend. And I guess it's safe to just leave brotli on as default. It's should just work if you put brotli on; in the nginx.conf.

Please correct me if I'm wrong. Sorry for any grammer mistakes or misspelling. My English is poor.

github-actions[bot] commented 6 months ago

Issue is now considered stale. If you want to keep it open, please comment :+1: