trankhacvy
commented
11 months ago Hello @NguyenPhuLoc666666 , nice work but there is room for improvement!
Requirements
- [x] All core functionalities present
- [x] Proper TypeScript implementation
- [ ] No eslint warnings & errors
- [ ] Husky & lint-staged integration !!
Final result: ❌ Failed
Feedback
We also have some comments for your work:
-
Using only one configuration file is recommended because using multiple configurations can lead to unexpected errors.
-
I noticed some linting errors in your code.
-
It seems like your lint-staged configuration isn't working. I'm able to commit without any linting checks.
-
Since we only have three types of dialogs, you might want to change the "dialog" type to a union type.
type DialogType = 'create-dialog' | 'delete-dialog' | 'info-dialog'
const handleOpenDialog = (dialog: DialogType, book: IBook): void => {
5 . When we assign a value to our variables, TypeScript can automatically figure out the type from that value. So, you don't have to explicitly declare the type for these kinds of variables.
link: https://df-frontend-2023-3lbw-nguyenphuloc666666.vercel.app/