search

Nheko-Reborn / mtxclient

Client API library for Matrix, built on top of libcurl
MIT License
40 stars 25 forks source link

Do not create thumbnail info if there is no thumbnail #24

Closed rnhmjoj closed 4 years ago

rnhmjoj commented 4 years ago

This should fix a longstanding issue in nheko; where image messages without a thumbnail have an empty thumbnail_info causing riot and maybe other clients to not display the image.

cc @deepbluev7-old

codecov[bot] commented 4 years ago

Codecov Report

Merging #24 into master will increase coverage by 0.33%. The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   70.48%   70.81%   +0.33%     
==========================================
  Files          65       65              
  Lines        3137     3139       +2     
==========================================
+ Hits         2211     2223      +12     
+ Misses        926      916      -10
Impacted Files Coverage Δ
lib/structs/events/common.cpp 74.52% <58.33%> (-0.48%) :arrow_down:
include/mtx/events.hpp 52.27% <0%> (+1.7%) :arrow_up:
lib/structs/events/messages/image.cpp 73.68% <0%> (+21.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82a1d8b...95d1792. Read the comment docs.

deepbluev7 commented 4 years ago

Yep, seems to work well, merged. Thank you!