Improved VoIP Signalling

[r0hit05]

Improved Signalling for 1:1 VoIP

MSC2746

To-Do

• [x] Add version check
• [x] Add invitee to m.call.invite
• [x] Add party_id to all VoIP events
• [x] Add new events
  • [x] m.call.select_answer
  • [x] m.call.reject
  • [x] m.call.negotiate
• [x] Add reason codes to m.call.hangup
• [x] Add custom struct RTCSessionDescriptionInit for session description objects
• [ ] Add DTMF
• [x] Change namespace for VoIP events to mtx::events::voip
• [x] Add tests

[deepbluev7]

One thing I don't see on your todo list yet, is adding some tests. We usually add at least a few tests to test if the events parse properly :3

(I guess you did already add one in the time I got to writing this message...)

[r0hit05]

One thing I don't see on your todo list yet, is adding some tests. We usually add at least a few tests to test if the events parse properly :3

(I guess you did already add one in the time I got to writing this message...)

I have added some of the trivial tests. I was thinking of making a separate voip.cpp file to test further features instead of doing them under messages.cpp?

[r0hit05]

Also, the To-Do list is incomplete. I would add more as and when I find out more things to do. Let me know if there are other things I need to add.

[deepbluev7]

I have added some of the trivial tests. I was thinking of making a separate voip to test further features instead of doing them under messages?

Sure, sounds good to me!

Also, the To-Do list is incomplete. I would add more as and when I find out more things to do. Let me know if there are other things I need to add.

I think updating all the call event types first is good enough for this PR. Then we should update Nheko to compile with the changed namespaces and merge both. Then after that we can work on implementing the signaling?

[r0hit05]

I have added some of the trivial tests. I was thinking of making a separate voip to test further features instead of doing them under messages?

Sure, sounds good to me!

Also, the To-Do list is incomplete. I would add more as and when I find out more things to do. Let me know if there are other things I need to add.

I think updating all the call event types first is good enough for this PR. Then we should update Nheko to compile with the changed namespaces and merge both. Then after that we can work on implementing the signaling?

Ok, that works for me.

[r0hit05]

I have added some of the trivial tests. I was thinking of making a separate voip to test further features instead of doing them under messages?

Sure, sounds good to me!

Also, the To-Do list is incomplete. I would add more as and when I find out more things to do. Let me know if there are other things I need to add.

I think updating all the call event types first is good enough for this PR. Then we should update Nheko to compile with the changed namespaces and merge both. Then after that we can work on implementing the signaling?

Since the structures are changed, I am not sure how I should do it. I can give default values to the newly added variables and leave them be till they have been implemented?

[deepbluev7]

Since the structures are changed, I am not sure how I should do it. I can give default values to the newly added variables and leave them be till they have been implemented?

We should only be reading and writing the unchanged values anyway, so the json we send should be the same, I think. So using the default values (or rather not using them) should be fine imo?

[deepbluev7]

Thank you, looks good to me!