search

Nheko-Reborn / nheko

Desktop client for Matrix using Qt and C++20.
https://nheko-reborn.github.io/
GNU General Public License v3.0
1.94k stars 201 forks source link

Room settings panel scrolls when it really doesn't need to #1143

Open Cadair opened 2 years ago

Cadair commented 2 years ago

Describe the bug

Opening the room settings panel on a display with enough vertical space to display all the settings should make the settings window larger so that it doesn't need to scroll by default.

Also, relatedly, it's really not obvious that that panel scrolls (there is no scroll indicator).

To Reproduce

  1. have high res monitor
  2. Open settings panel
  3. forget that there are settings at the bottom

What happened?

No response

Expected behavior

No response

Screenshots

No response

Version

0.10.0-5ba444b5

Operating system

Linux

Installation method

No response

Qt version

No response

C++ compiler

No response

Desktop Environment

No response

Did you use profiles?

Relevant log output

No response

Backtrace

No response

LorenDB commented 1 year ago

https://gist.github.com/LorenDB/4e4a0cab98342b81c319b557310de3bd has a patch that will handle this by expanding the window to fit the contents. There was some pushback on this though, so I'm retracting that PR.