search

Nheko-Reborn / nheko

Desktop client for Matrix using Qt and C++20.
https://nheko-reborn.github.io/
GNU General Public License v3.0
1.82k stars 196 forks source link

SCREENSHARE_XDP does nothing #1613

Open checkraisefold opened 7 months ago

checkraisefold commented 7 months ago

Describe the bug

The option SCREENSHARE_XDP in CMakeLists.txt added in #1411 has apparently always does nothing. This is an issue for any potential Windows build in the future supporting gstreamer, since there is no Qt D-Bus API/XDP on Windows, and such these files have to be skipped.

To Reproduce

  1. Use option SCREENSHARE_XDP
  2. Does nothing
nico-famedly commented 7 months ago

I guess the idea was to use that as a define in the C++ code, but that seems to have never happened? At least this doesn't require any extra libraries, so it has a somewhat small impact, it would just show a button, that shouldn't exist.

checkraisefold commented 7 months ago

I guess the idea was to use that as a define in the C++ code, but that seems to have never happened? At least this doesn't require any extra libraries, so it has a somewhat small impact, it would just show a button, that shouldn't exist.

Yes, the define should in theory prevent the ScreencastPortal from getting compiled (currently only checks GSTREAMER_AVAILABLE) and also disable stuff that uses ScreencastPortal.