search

Nheko-Reborn / nheko

Desktop client for Matrix using Qt and C++20.
https://nheko-reborn.github.io/
GNU General Public License v3.0
1.89k stars 199 forks source link

Editing a message while the message is being sent causes the edit to be lost #1713

Open antoyo opened 5 months ago

antoyo commented 5 months ago

Describe the bug

We lose message edits if those edits are done before the message is sent.

Possibly a regression of #574.

To Reproduce

  1. Send a message.
  2. While it's still being sent, edit the same message.
  3. See that the edit is not taken into account.

What happened?

The edit was lost.

Expected behavior

The message should be edited correctly.

Screenshots

No response

Version

nheko 0.11.3

Operating system

Linux

Installation method

Some repository (AUR, homebrew, distribution repository, PPA, etc)

Qt version

No response

C++ compiler

No response

Desktop Environment

i3

Did you use profiles?

Relevant log output

No response

Backtrace

No response

balsoft commented 3 months ago

I'm pretty sure I've fixed this at some point :( I might take a look again if I have time

geekosaur commented 2 months ago

I just reproduced this on 0.12.0-24c687d