search

Nheko-Reborn / nheko

Desktop client for Matrix using Qt and C++20.
https://nheko-reborn.github.io/
GNU General Public License v3.0
1.89k stars 199 forks source link

When an attachment is being uploaded and a reply has been selected, the attachment will be sent as reply #1743

Open farooqkz opened 3 months ago

farooqkz commented 3 months ago

Describe the bug

You select some file for upload and it is being uploaded. While it is being uploaded you select a reply and suddenly the upload gets complete and sent as a reply.

To Reproduce

  1. Select a big enough file to upload so that it'll take some time to get uploaded
  2. Start a reply but don't send anything
  3. Wait for the upload to finish
  4. See that your file, like a photo, is being sent as a reply which is an undesirable outcome

What happened?

No response

Expected behavior

The image or any other file should be sent as normal. Not as reply.

Screenshots

No response

Version

0.11.3-791cb660

Operating system

Linux

Installation method

Flathub

Qt version

No response

C++ compiler

No response

Desktop Environment

KDE Plasma

Did you use profiles?

Relevant log output

No response

Backtrace

No response

deepbluev7 commented 3 months ago

Well, being able to send images and other files as replies is intentional, but we could improve the UX around that a bit (so that we don't wait for the upload to complete before checking if the event should be a reply).