search

Nhowka / Elmish.Bridge

Create client-server Fable-Elmish apps keeping a single mindset
MIT License
139 stars 17 forks source link

Websocket connection fails in IE11 / Edge #13

Closed 0x53A closed 5 years ago

0x53A commented 5 years ago

Apologies for even mentioning IE11 ...

We don't have a strong requirement for IE11, but it would be really nice to be able to still support it.

1) I had to polyfill URL with url-polyfill 2) The websocket ctor throws because for some reason there is a hash at the end:

grafik

If I set a breakpoint, remove the # then continue, it works.

Do you have any idea where the hash comes from? Maybe it is an issue with url-polyfill, I have no clue.

What do you think about just adding a TrimEnd('#')?

EDIT: Same behavior with Edge (EdgeHTML 16.16299)

Nhowka commented 5 years ago

Weird. On Chrome that was solved by giving an empty string to the hash.

https://github.com/Nhowka/Elmish.Bridge/blob/6b639068774f5ce41a78a36e4ba53dba7566f0a6/src/Client/Library.fs#L25

Maybe the polyfill behaves differently, but TrimEnd('#') could indeed help. I'll try using it to fix this problem.

Nhowka commented 5 years ago

Is version 1.2.1 working?

0x53A commented 5 years ago

Looks good in a quick 5 minute test.

Thank you! 🐧