search

Nhowka / Elmish.Bridge

Create client-server Fable-Elmish apps keeping a single mindset
MIT License
139 stars 17 forks source link

Dom memory Leak #57

Open OnurGumus opened 1 year ago

OnurGumus commented 1 year ago

I see the mappings are attached to dom tree, but not cleaned on dispose here:

https://github.com/Nhowka/Elmish.Bridge/blob/0134e2ad4566f5c254c5e80add39edbbef17371c/src/Client/Library.fs#L28C11-L28C11

Isn't this leaking, when I don't need elmish bridge?

OnurGumus commented 1 year ago

Ok these are not leaking, but the map retains those callbacks which eventually leaks. Dispose also should remove relevant keys from the map.