Handle large messages received by Suave server

Nhowka / Elmish.Bridge

Create client-server Fable-Elmish apps keeping a single mindset

MIT License

139 stars 17 forks source link

Handle large messages received by Suave server #61

Closed rob-oehm-automation closed 1 month ago

rob-oehm-automation commented 1 month ago

This change fixes a bug that messages would never complete and be received by the server when they were large.

Adds handling for the Continuation case which occurs when receiving large (empirically >64kB) messages.
Makes minor optimization to avoid list allocation in the common case of a single data element
Adds a Break() to pick up any other unhandled messages in DEBUG mode. This code was how I identified the bug but happy to delete it.

Nhowka commented 1 month ago

Thanks for the contribution and bringing the continuation case to our attention! The Giraffe implementation has that abstracted, masking the issue. I like the idea of optimizing the single data case. I'll do some minor changes and upload a new version.

Nhowka commented 1 month ago

Version 7.0.1 published with the fix. Thanks again!