NiHoel / Anno1800Calculator

Calculator for the production and consumption of goods in the computer game Anno 1800
MIT License
102 stars 28 forks source link

Dockland features don't seem to work properly with construction materials #54

Closed FIrgolitsch closed 3 years ago

FIrgolitsch commented 3 years ago

Hi,

The calculation for buildings required of construction material buildings doesn't seem to work correctly. It seems that the overproduction isn't quite right. It's usually on 0 (or 0.01) t/s, and when exporting goods with Docklands it subtracts the required production for the export from the overproduction, which for the construction materials is already at 0. This leads to the building required calculation to show the additional building required for the trade, on top of that which is already there. See screenshots below for a more clear explanation.

image image image The first two screenshots are made under the same situation shown in the third. I would expect that the over production would be 1.5 t/s (4 t/s for 3 steelworks, minus 2.5 t/s for the Docklands export/extra demand). Like I said before, it seems that the overproduction is always at 0 for construction materials, which leads to some weird calculations.

FIrgolitsch commented 3 years ago

I had some time to look at the issue today, and created a pull request (#55) which has my edits which fixes the issue for me.