search

NiLuJe / FBInk

FrameBuffer eInker, a small tool & library to print text & images to an eInk Linux framebuffer
https://www.mobileread.com/forums/showthread.php?t=299110
GNU General Public License v3.0
332 stars 23 forks source link

Makefile: add check for CHOST #39

Closed jdek closed 5 years ago

jdek commented 5 years ago

Generally, cross compilation toolchain prefixes include the '-' at the end. Don't want to change your setup, so just fallback to check a more standard CHOST cross compile if CROSS_TC is unset.

pgaskin commented 5 years ago

I agree that CROSS_TC is less standard than CHOST (I've only seen it in NiLuJe's stuff), but the only place I've seen CHOST is in Gentoo stuff and a few projects. But, I've seen CROSS_PREFIX a bit more, and CROSS_COMPILE is used in the Linux kernel (with the dash).

jdek commented 5 years ago

I'm not really bothered if you want to call it CHOST, CROSS_PREFIX or CROSS_COMPILE, just that it doesn't add an extra -. Which would you merge?

NiLuJe commented 5 years ago

Yeah, CHOST is out because it has a very specific meaning in Gentoo, and you basically shouldn't ever set it yourself anywhere ;).

NiLuJe commented 5 years ago

I have an extremely vague preference for CROSS_PREFIX, since it's also set in my own envs, but, since I'm usually using CROSS_TC myself, I have no strong opinion, both CROSS_PREFIX or CROSS_COMPILE would be fine with me ;).

jdek commented 5 years ago

I set it as CROSS_COMPILE so it's similar to the kernel.

NiLuJe commented 5 years ago

That's perfectly fine with me, thanks! ;).