NiLuJe / FBInk

FrameBuffer eInker, a small tool & library to print text & images to an eInk Linux framebuffer
https://www.mobileread.com/forums/showthread.php?t=299110
GNU General Public License v3.0
332 stars 23 forks source link

[PW5 MTK] Fix swipe animations with a tiny refresh area #69

Closed yparitcher closed 2 years ago

yparitcher commented 2 years ago

koreader/koreader#9245 koreader/koreader-base/pull/1494

The simplest way to trigger this is fbink -K direction=LEFT,steps=12 -s width=11

The MTK Driver will crash if given a area smaller than the number of steps. If direction is L/R and w is smaller or if it is U/D and h is smaller Being as one generally will only want animations on a larger area, and I am too lazy to test for direction, disable animations when w or h is less than steps.

I did not add any error handling etc, feel free to spice it up.


This change is Reviewable

yparitcher commented 2 years ago

Not tested

NiLuJe commented 2 years ago

Oh, makes sense, thanks for the detective work ;).

NiLuJe commented 2 years ago

Thanks!