Niall7459 / HolographicExtension

Add easy to create animations and placeholders into HolographicDisplays.
GNU General Public License v3.0
6 stars 14 forks source link

Formatting/color codes removes using {placeholders} #22

Closed Andre601 closed 3 years ago

Andre601 commented 4 years ago

When you set a line like /hd addline test Currently Online: &b{slow}%server_online% does the extension remove any color code whatsoever set before the {slow} placeholder.

This doesn't happen when setting the color/formatting code after it, but it's still annoying.

Additionally does the placeholder add an extra space, which would be nice, if it could be removed in some way.

MaximMaximS commented 3 years ago

Yes, that would be very cool, I have the same issue.

Niall7459 commented 3 years ago

Spaces: Put them where you need a space anyway, for some reason a space has been necessary to trigger the hologram to update.

Colors: Put codes after refresh placeholders {slow}&b%server_online% instead of &b{slow}%server_online%

Andre601 commented 3 years ago

Thanks for nothing... It's not like I mentioned this before. -_-

MaximMaximS commented 3 years ago

...and I need colour from the previous placeholder...

Niall7459 commented 3 years ago

Should be able to do the same {slow}%placeholder_with_colour%Some text

MaximMaximS commented 3 years ago

lmao, I need colour from the first placeholder on the second placeholder.

Andre601 commented 3 years ago

Can this not be handled through like commands? I mean HD itself also has updates for like server placeholder and something, so perhaps something similar rather than a dedicated placeholder would be better.

Niall7459 commented 3 years ago

@MaximMaximS How are you arranging the placeholders currently?

Can this not be handled through like commands? I mean HD itself also has updates for like server placeholder and something, so perhaps something similar rather than a dedicated placeholder would be better.

I am open for any ideas that can improve/overhaul the current "refresh holder" method. Holographic extension is also open sourced. PRs are welcome if you feel up to it.

MaximMaximS commented 3 years ago

@MaximMaximS How are you arranging the placeholders currently?

Can this not be handled through like commands? I mean HD itself also has updates for like server placeholder and something, so perhaps something similar rather than a dedicated placeholder would be better.

I am open for any ideas that can improve/overhaul the current "refresh holder" method. Holographic extension is also open sourced. PRs are welcome if you feel up to it.

&6{medium}%parseother_{parkour_leaderboard_svarta_player1}{luckperms_prefix}%{medium}%parkour_leaderboard_svarta_player_1% &e- {medium}%parkour_leaderboard_svarta_time_1% - Smrti: {medium}%parkour_leaderboard_svarta_deaths_1%'

MaximMaximS commented 3 years ago

Or just like {medium}%parseother_{parkour_leaderboard_svarta_player1}{luckperms_prefix}%{medium}%parkour_leaderboard_svarta_player_1%

Niall7459 commented 3 years ago

You only need 1x{medium}, can use:

&6%parseother_{parkour_leaderboard_svarta_player_1}_{luckperms_prefix}% %parkour_leaderboard_svarta_player_1% &e- %parkour_leaderboard_svarta_time_1% - Smrti:{medium}%parkour_leaderboard_svarta_deaths_1%'

Or move the {medium} somewhere else, if it interfere with colours

MaximMaximS commented 3 years ago

Can it be after placeholder?