Fix update check when currentVersion is greater than latestVersion.

Niall7459 / HolographicExtension

Add easy to create animations and placeholders into HolographicDisplays.

GNU General Public License v3.0

6 stars 14 forks source link

Fix update check when currentVersion is greater than latestVersion. #26

Closed fabianmakila closed 4 years ago

fabianmakila commented 4 years ago

Fixes the remaining cache issue in #25

Niall7459 commented 4 years ago

Thank you for your contribution however using compareTo on a String is unlikely to provide consistent results.

The cache is enforced by the API, essentially it's out of our control

fabianmakila commented 4 years ago

I agree what you said. The API not really being our problem was what first drove me to use compareTo instead of more accurate method. But I completely understand if you don't want this in!