Niall7459 / HolographicExtension

Add easy to create animations and placeholders into HolographicDisplays.
GNU General Public License v3.0
6 stars 14 forks source link

CHUNk placeholder VAULT tps peaks! #34

Open Bricec6 opened 4 years ago

Bricec6 commented 4 years ago

Hello I noticed that I had lags on my server, after several tests etc, I noticed that the placeholders of vault economy(see photo) repeat every x seconds create peaks of tps on the servers because it makes bug the complete chunk. image

the check pauses and then resumes (see config), which causes tps peaks image

if I move away from this placeholder, for example I put myself on a par chunk, the place where it was before doesn't create peaks anymore, but the new place where I will create peaks of tps

i use Holographics Display and HolographicExtensions(for placeholder)

config: image

it should be known that only vault causes this problem the other permanent check plugins like bentobox or dkcoins do not cause this kind of problem.

I reported that bug to vault, too .https://github.com/MilkBowl/Vault/issues/807

thank you!

Niall7459 commented 4 years ago

This most likely isn't a Vault issue. I don't see why holographic extension would cause a noticeable TPS increase either. The bal top placeholders are calculated asynchronously. If you could do a timings report that would help.

Thanks.

Bricec6 commented 4 years ago

Hello I'm not at home at the moment, I'll be back in a few days, in my timings the peaks of tps is displayed as world tracker 2, and makes peaks at the predefined rhythm of {slowest} after the placeholders, if I don't put {slowest} and that I refresh there will be no more peaks of tps, but obviously the top balance will not update.

Bricec6 commented 4 years ago

I made some tests before seeing that it was this type of hologram that was a problem at first I thought it was my other plugins such as mythicmobs or crate reloaded, because there were only the 3 plugins (including yours) in the radius of the peak time, for example if I deviate from ~80 blocks of the hologram balance top, my tps didn't drop.

Bricec6 commented 4 years ago

I'll be able to make a video of the problem when I get home but I'm 100% sure the problem is with