search

Niall7459 / HolographicExtension

Add easy to create animations and placeholders into HolographicDisplays.
GNU General Public License v3.0
6 stars 14 forks source link

Update checker setting ignored? #37

Open SlimeDog opened 4 years ago

SlimeDog commented 4 years ago

Spigot 1.16.1 HE 1.10.9

config.yml

enable-update-check: false

but network log shows

Sun Jun 28 17:40:10 PDT 2020: Intercepted outgoing connection to host 'api.spigotmc.org'
        at net.kitesoftware.holograms.updater.UpdateChecker.lambda$checkUpdates$0(UpdateChecker.java:47)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1692)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
        at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)

We block these sorts of requests at the network (we have our own automagical update checker). The failed connection produces a Spigot log ERROR

[17:58:56] [Server thread/ERROR]: java.io.IOException: Connect failed
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]: java.io.IOException: Connect failed
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at me.lucko.networkinterceptor.interceptors.ProxySelectorInterceptor$LoggingSelector.select(ProxySelectorInterceptor.java:59)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1181)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1081)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:177)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1587)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1515)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:250)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at net.kitesoftware.holograms.updater.UpdateChecker.lambda$checkUpdates$0(UpdateChecker.java:47)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1692)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
[17:58:58] [ForkJoinPool.commonPool-worker-3/WARN]:     at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)

Requests:

Please advise.