Niall7459 / HolographicExtension

Add easy to create animations and placeholders into HolographicDisplays.
GNU General Public License v3.0
6 stars 14 forks source link

1.17/1.18 support & performance improvements #45

Open kixmc opened 3 years ago

kixmc commented 3 years ago

No longer updating or fixing issues related to this. Use DecentHolograms instead.

It's a drop in replacement for Holographic Displays with native support for PAPI (you just have to run the /dh convert HolographicDisplays to migrate). It also has some other nifty features HD has lacked over the years, like individual line height adjustments, pages, and some other stuff. I've been using it on my server for about a week and have had no issues. Performance is better compared to HD+HE, too.

It just doesn't make sense for me to continue to spend time on this with a better alternative available. Thanks for understanding! Take care all :)


Original Post

Adds support for 1.17, 1.17.1 and 1.18 as well as some performance improvements. Tested, everything seems to work as expected :)

Performance improvements were in response to issue https://github.com/Niall7459/HolographicExtension/issues/41 and my own experiences. Prior to my changes I noticed significant micro stuttering and was able to link it to this plugin via a spark profile. Haven't had any more stuttering issues so far

Notes to those who plan on using this:

1.17.1 and below https://drive.google.com/u/3/uc?id=1QyxF_dHIvlkSlMMcILBmtBOzyXYO-M6j&export=download

1.18 and above https://drive.google.com/u/3/uc?id=1y4ZQiJjabFHQBG8HyN9iT_gXjTsF6MXr&export=download

MCSulphate commented 3 years ago

Hey, thanks for the work :) Unfortunately I can't seem to get it working. I've got the latest holo displays, placeholderapi, vault, have the vault extension installed for papi, but the placeholders are not being parsed for the holograms. An example of what I have: {slowest}%vault_eco_balance%.

Any help appreciated :)

quick007 commented 3 years ago

Yea, this doesn't work.

therbz commented 3 years ago

Works perfectly fine on 1.17.1 Purpur

codebycam commented 3 years ago

Cheers for doing this PR! I hope it gets merged soon. I did notice https://github.com/Niall7459/HolographicExtension/issues/47 is also occurring for me running your version.

kixmc commented 3 years ago

Cheers for doing this PR! I hope it gets merged soon. I did notice #47 is also occurring for me running your version.

47 and related errors should be resolved after the latest commits. Let me know πŸ‘

Download link has been updated in my initial post

Hey, thanks for the work :) Unfortunately I can't seem to get it working. I've got the latest holo displays, placeholderapi, vault, have the vault extension installed for papi, but the placeholders are not being parsed for the holograms. An example of what I have: {slowest}%vault_eco_balance%.

Any help appreciated :)

Hmm, what version and type is your server? Try giving the latest a try

kixmc commented 3 years ago

Yea, this doesn't work.

I can't do anything if you give me any information. Please give any errors as well as your server version, type, and your HD & PL versions

codebycam commented 3 years ago

47 and related errors should be resolved after the latest commits. Let me know πŸ‘

Download link has been updated in my initial post

Hey, this did resolve that issue, cheers! :)

JHarris12345 commented 2 years ago

Theres an issue where the %statistic_time_played% placeholder changes to show people other peoples playtime when they teleport into the area

kixmc commented 2 years ago

Theres an issue where the %statistic_time_played% placeholder changes to show people other peoples playtime when they teleport into the area

Not sure the exact cause of this, however after the holo refreshes it fixes itself (at least in my testing). For now just use a faster refresh rate

JHarris12345 commented 2 years ago

Theres an issue where the %statistic_time_played% placeholder changes to show people other peoples playtime when they teleport into the area

Not sure the exact cause of this, however after the holo refreshes it fixes itself (at least in my testing). For now just use a faster refresh rate

This wont fix it as it is still glithcy for the split seconds.

JHarris12345 commented 2 years ago

Also how do I fix this issue https://pastebin.com/f2ZgjeR0

Thin-Troll commented 2 years ago

will there be hex (rgb) support?

Alijkaz commented 2 years ago

Having no issues running it on a Purpur 1.17 server. Thanks!

SofyanTauridOdeMadi commented 2 years ago

Thanks Bruh !

SpaceYoshi commented 2 years ago

Thanks for making this! Only issue that I still have, is that the per-player placeholders are not displaying correctly. The stats of the first player in the area of the holo are displayed to everyone, despite using a high refresh-rate. {fast} Sometimes the placeholders bind to a single player at random, until the player leaves the area.

JHarris12345 commented 2 years ago

9D5D6931-D9C2-4FD1-B1C0-3FB26DDD50FC

i also said this

JHarris12345 commented 2 years ago

Anything on that issue above?

PetyXbron commented 2 years ago

@kixmc will you update this pull request for Minecraft version 1.18?

kixmc commented 2 years ago

Anything on that issue above? @kixmc will you update this pull request for Minecraft version 1.18?

Untested however the issue with placeholders showing other players' values should be resolved, and 1.18 should also be supported now. Compiled jar is linked in my initial post

PetyXbron commented 2 years ago

So I downloaded and installed version 1.10.11. With 3.0.0-SNAPSHOT HolographicDisplays and PAPI 2.10.9. I used command /hd create test {slowest}%server_version% and it showed this; Screenshot_20211208-232118_Minecraft.png Placeholder updated (I tried %player_time% and it was updating really fast) but the time update variable didn't hide. What am I doing wrong?

PetyXbron commented 2 years ago

I tried to download your jar file again and try it. I used /hd create test {medium}%player_time% And it still does ignore the time update variable. image

ItsSynchro commented 2 years ago

hi, im constantly getting these errors thrown https://pastebin.com/r9NNYwi2

PetyXbron commented 2 years ago

hi, im constantly getting these errors thrown https://pastebin.com/r9NNYwi2

Same issue, same error. 1.18.1 git-Paper-98 https://paste-bin.xyz/26718

kixmc commented 2 years ago

hi, im constantly getting these errors thrown https://pastebin.com/r9NNYwi2

Same issue, same error. 1.18.1 git-Paper-98 https://paste-bin.xyz/26718

Does the 1.17 version work?

kixmc commented 2 years ago

No longer updating or fixing issues related to this. Use DecentHolograms instead.

It's a drop in replacement for Holographic Displays with native support for PAPI (you just have to run the /dh convert HolographicDisplays to migrate). It also has some other nifty features HD has lacked over the years, like individual line height adjustments, pages, and some other stuff. I've been using it on my server for about a week and have had no issues. Performance is better compared to HD+HE, too.

It just doesn't make sense for me to continue to spend time on this with a better alternative available. Thanks for understanding! Take care all :)