Closed Unique-Divine closed 5 months ago
This update enhances code clarity and reusability related to burn coin supply checks within the inflation module. By moving these checks to separate functions, the changes facilitate better testing and maintenance. Additionally, the update aims to align with best practices by using bank total supply queries for validating state changes in MsgBurn, addressing specific objectives from linked issues.
Files | Change Summary |
---|---|
x/inflation/keeper/keeper_test.go |
Extracted burn coin supply checks to separate functions. |
x/inflation/keeper/msg_server_test.go |
Utilized separate functions for burn coin supply checks. |
Objective | Addressed | Explanation |
---|---|---|
Use bank total supply queries to validate state changes in MsgBurn (#1825) | ✅ |
🐰✨
Changes afoot, in code we trust,
Clarity blooms, as functions adjust.
Burn the coins, but check them right,
In tests we trust, to code with might.
🌟🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
I ended up creating #1828 since I didn't realize you worked on it also.
I think we can close this in favor of #1828, since it contains all the test changes in this PR + negative test cases.
Summary by CodeRabbit