NibiruChain / nibiru

Nibiru Chain: The breakthrough smart contract platform ushering in the next era of money. Nibiru powers an ecosystem of dApps including perps, RWAs, and more.
https://nibiru.fi
Apache License 2.0
182 stars 200 forks source link

feat(eth): Collections encoders for bytes, Ethereum addresses, and Ethereum hashes #1841

Closed Unique-Divine closed 4 months ago

Unique-Divine commented 4 months ago

Purpose / Abstract

feat(eth): Collections encoders for bytes, Ethereum addresses, and Ethereum hashes

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

This update introduces significant improvements to Ethereum transaction handling within the Nibiru EVM features. It includes enhancements like EIP-712 encoding for transactions, Ethereum address and hash validation functions, Ethereum chain ID parsing, and HD path management. These changes aim to streamline Ethereum-related operations and ensure compatibility with Ethereum standards.

Changes

File Path Change Summary
eth/ethereum/eip712/... Adds functionality for EIP-712 encoding, decoding, and message handling for Ethereum transactions.
eth/types/assert.go Introduces functions for Ethereum address and hash validation and management.
eth/types/chain_id.go Adds Ethereum chain ID validation and parsing capabilities.
eth/types/hdpath.go Introduces features for managing HD paths in Ethereum, including defining constants and path creation.
eth/ethereum/eip712/types.go Implements EIP-712 type creation and management for Ethereum transactions.
eth/ethereum/eip712/preprocess.go Introduces a function to reformat Ledger-signed Cosmos transactions for Ethereum transaction compatibility.
eth/types/codec.go, eth/types/state_encoder_test.go Adds functionality for codec registration and testing for Ethereum storage abstractions.

Poem

🐇✨
Oh, in the realm of Ethereum's might,
Where EIP-712 dances with delight.
Addresses checked, paths well-trod,
Each byte encoded, each test a nod.
Let the blockchain sing, our quest in sight,
As we journey through the code's starry night. 🌟
🐇💻


Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between 410bc14f3aa39c840825b885f33016ca2de261f0 and 045e54734ad51136162dc20674e577e653e2c240.
Files selected for processing (21) * LICENSE.md (2 hunks) * eth/crypto/codec/amino.go (1 hunks) * eth/crypto/codec/codec.go (1 hunks) * eth/crypto/ethsecp256k1/ethsecp256k1.go (1 hunks) * eth/crypto/hd/algorithm.go (1 hunks) * eth/crypto/keyring/options.go (1 hunks) * eth/encoding/codec/codec.go (1 hunks) * eth/encoding/config.go (1 hunks) * eth/ethereum/eip712/domain.go (1 hunks) * eth/ethereum/eip712/eip712.go (1 hunks) * eth/ethereum/eip712/eip712_legacy.go (1 hunks) * eth/ethereum/eip712/encoding.go (1 hunks) * eth/ethereum/eip712/encoding_legacy.go (1 hunks) * eth/ethereum/eip712/message.go (1 hunks) * eth/ethereum/eip712/preprocess.go (1 hunks) * eth/ethereum/eip712/types.go (1 hunks) * eth/types/assert.go (1 hunks) * eth/types/chain_id.go (1 hunks) * eth/types/codec.go (1 hunks) * eth/types/hdpath.go (1 hunks) * eth/types/state_encoder_test.go (1 hunks)
Files skipped from review as they are similar to previous changes (20) * eth/crypto/codec/amino.go * eth/crypto/codec/codec.go * eth/crypto/ethsecp256k1/ethsecp256k1.go * eth/crypto/hd/algorithm.go * eth/crypto/keyring/options.go * eth/encoding/codec/codec.go * eth/encoding/config.go * eth/ethereum/eip712/domain.go * eth/ethereum/eip712/eip712.go * eth/ethereum/eip712/eip712_legacy.go * eth/ethereum/eip712/encoding.go * eth/ethereum/eip712/encoding_legacy.go * eth/ethereum/eip712/message.go * eth/ethereum/eip712/preprocess.go * eth/ethereum/eip712/types.go * eth/types/assert.go * eth/types/chain_id.go * eth/types/codec.go * eth/types/hdpath.go * eth/types/state_encoder_test.go
Additional comments not posted (1)
LICENSE.md (1)
`189-189`: Update the copyright year and company name to reflect current details.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.