search

NibiruChain / nibiru

Nibiru Chain: The breakthrough smart contract platform ushering in the next era of money. Nibiru powers an ecosystem of dApps including perps, RWAs, and more.
https://nibiru.fi
Apache License 2.0
182 stars 200 forks source link

feat(eth-rpc): Conversion types and functions between Ethereum txs and blocks and Tendermint ones. #1856

Closed Unique-Divine closed 4 months ago

Unique-Divine commented 4 months ago

Purpose / Abstract

[!TIP]

  1. Please review parent PRs first.

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

This update enhances Ethereum integration with features like in-memory EventBus for real-time event management, and new Ethereum RPC functionalities. It also includes significant refactoring, renaming the types package to eth and updating numerous references and import paths across various files. Testing enhancements and new functionalities in Ethereum transaction handling and RPC operations are notable additions.

Changes

Files or Directories Change Summary
eth-pubsub, eth-rpc Added EventBus for real-time event management and new Ethereum RPC functionalities.
eth/*.go, eth/crypto/hd/*.go, eth/eip712/*, eth/encoding/codec/codec.go, eth/encoding/config_test.go, eth/rpc/*, proto/eth/* Renamed package from types to eth and updated import paths and references.
eth/assert_test.go, eth/chain_id_test.go, eth/codec_test.go, eth/crypto/hd/algorithm_test.go, eth/crypto/hd/benchmark_test.go, eth/safe_math_test.go, eth/rpc/rpc_test.go, x/evm/genesis_test.go, x/evm/evmtest/eth_test.go Enhanced testing for various functionalities including Ethereum transactions, addresses, and safe math operations.
cmd/nibid/cmd/root.go, cmd/nibid/cmd/testnet.go Updated CLI descriptions and package aliases for better clarity and structure.
x/evm/README.md, x/evm/genesis.go, x/evm/params.go, x/evm/tx.go, x/evm/evmtest/eth.go Introduced and updated functionalities related to EVM genesis accounts, parameters, and transaction handling.

Poem

🐰🌟 In the land of code, where the bits do hop,
A rabbit worked, with no intent to stop.
From Ethereum's weave, to Tendermint's thread,
An EventBus blooms, and new paths are tread.
Cheers to the devs, with each merge and commit,
In the blockchain burrow, where the CodeRabbits sit!
🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 58.47619% with 218 lines in your changes are missing coverage. Please review.

Project coverage is 71.97%. Comparing base (ffcea96) to head (045cf6d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1856 +/- ## ========================================== + Coverage 68.59% 71.97% +3.37% ========================================== Files 176 183 +7 Lines 10091 10514 +423 ========================================== + Hits 6922 7567 +645 + Misses 2747 2475 -272 - Partials 422 472 +50 ``` | [Files](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1856?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | Coverage Δ | | |---|---|---| | [cmd/nibid/cmd/testnet.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1856?src=pr&el=tree&filepath=cmd%2Fnibid%2Fcmd%2Ftestnet.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-Y21kL25pYmlkL2NtZC90ZXN0bmV0Lmdv) | `73.30% <100.00%> (ø)` | | | [eth/assert.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1856?src=pr&el=tree&filepath=eth%2Fassert.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-ZXRoL2Fzc2VydC5nbw==) | `100.00% <ø> (ø)` | | | [eth/chain\_id.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1856?src=pr&el=tree&filepath=eth%2Fchain_id.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-ZXRoL2NoYWluX2lkLmdv) | `86.66% <ø> (ø)` | | | [eth/codec.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1856?src=pr&el=tree&filepath=eth%2Fcodec.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-ZXRoL2NvZGVjLmdv) | `100.00% <100.00%> (ø)` | | | [eth/crypto/ethsecp256k1/ethsecp256k1.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1856?src=pr&el=tree&filepath=eth%2Fcrypto%2Fethsecp256k1%2Fethsecp256k1.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-ZXRoL2NyeXB0by9ldGhzZWNwMjU2azEvZXRoc2VjcDI1NmsxLmdv) | `68.67% <ø> (ø)` | | | [eth/eip712/domain.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1856?src=pr&el=tree&filepath=eth%2Feip712%2Fdomain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-ZXRoL2VpcDcxMi9kb21haW4uZ28=) | `100.00% <ø> (ø)` | | | [eth/eip712/eip712.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1856?src=pr&el=tree&filepath=eth%2Feip712%2Feip712.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-ZXRoL2VpcDcxMi9laXA3MTIuZ28=) | `100.00% <ø> (ø)` | | | [eth/eip712/encoding.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1856?src=pr&el=tree&filepath=eth%2Feip712%2Fencoding.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-ZXRoL2VpcDcxMi9lbmNvZGluZy5nbw==) | `80.70% <100.00%> (ø)` | | | [eth/eip712/encoding\_legacy.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1856?src=pr&el=tree&filepath=eth%2Feip712%2Fencoding_legacy.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-ZXRoL2VpcDcxMi9lbmNvZGluZ19sZWdhY3kuZ28=) | `79.41% <100.00%> (ø)` | | | [eth/eip712/message.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1856?src=pr&el=tree&filepath=eth%2Feip712%2Fmessage.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-ZXRoL2VpcDcxMi9tZXNzYWdlLmdv) | `84.12% <ø> (ø)` | | | ... and [28 more](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1856?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | |