search

NibiruChain / nibiru

Nibiru Chain: The breakthrough smart contract platform ushering in the next era of money. Nibiru powers an ecosystem of dApps including perps, RWAs, and more.
https://nibiru.fi
Apache License 2.0
182 stars 200 forks source link

refactor(oracle): add oracle slashing events #1859

Closed k-yang closed 4 months ago

k-yang commented 4 months ago

Purpose / Abstract

coderabbitai[bot] commented 4 months ago

Walkthrough

The recent changes revolve around integrating a slashingKeeper component into key structures within the NibiruApp and its oracle module. These modifications include adding the slashingKeeper to the Keeper structures, adjusting function parameters to support slashing operations, and updating utility and test configurations. These enhancements aim to improve the management of validator penalties such as slashing and jailing, bolstering governance and security in the application.

Changes

Files Summary of Changes
app/keepers.go, x/oracle/keeper/... Introduced slashingKeeper in Keeper structs and updated function parameters for slashing operations.
x/oracle/keeper/slash.go Modified logging and argument order in slashing and jailing functions.
x/oracle/keeper/test_utils.go, x/oracle/types/expected_keeper.go Enhanced test setups and interfaces to support new slashing functionality.

Poem

🐰✨
Oh, in the land of code and byte,
A rabbit hopped through the night.
With each leap, a line refined,
Slashing bugs with keen mind.
Jailing errors, setting right,
In the glow of moonlight bright. 🌕🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.59%. Comparing base (45bb20c) to head (0bc3a6a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1859 +/- ## ========================================== + Coverage 68.58% 68.59% +0.01% ========================================== Files 176 176 Lines 10087 10091 +4 ========================================== + Hits 6918 6922 +4 Misses 2747 2747 Partials 422 422 ``` | [Files](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1859?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | Coverage Δ | | |---|---|---| | [app/keepers.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1859?src=pr&el=tree&filepath=app%2Fkeepers.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2tlZXBlcnMuZ28=) | `99.12% <100.00%> (ø)` | | | [x/oracle/keeper/keeper.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1859?src=pr&el=tree&filepath=x%2Foracle%2Fkeeper%2Fkeeper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9vcmFjbGUva2VlcGVyL2tlZXBlci5nbw==) | `86.02% <100.00%> (+0.15%)` | :arrow_up: | | [x/oracle/keeper/slash.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1859?src=pr&el=tree&filepath=x%2Foracle%2Fkeeper%2Fslash.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9vcmFjbGUva2VlcGVyL3NsYXNoLmdv) | `84.37% <100.00%> (-0.48%)` | :arrow_down: | | [x/oracle/keeper/sudo.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1859?src=pr&el=tree&filepath=x%2Foracle%2Fkeeper%2Fsudo.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9vcmFjbGUva2VlcGVyL3N1ZG8uZ28=) | `94.28% <100.00%> (ø)` | | | [x/oracle/keeper/test\_utils.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1859?src=pr&el=tree&filepath=x%2Foracle%2Fkeeper%2Ftest_utils.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9vcmFjbGUva2VlcGVyL3Rlc3RfdXRpbHMuZ28=) | `96.70% <100.00%> (+0.07%)` | :arrow_up: |