Closed matthiasmatt closed 4 months ago
The recent changes involve updating string-related methods and imports across various modules, focusing on removing the gogoproto_stringer
option from protobuf message definitions. This adjustment affects how strings are handled in the codebase, impacting both production code and tests.
Files & Paths | Change Summaries |
---|---|
proto/eth/types/v1/account.proto proto/nibiru/oracle/v1/oracle.proto proto/nibiru/sudo/v1/state.proto proto/nibiru/tokenfactory/v1/state.proto |
Removed gogoproto_stringer option from specified messages. |
x/oracle/types/params.go x/oracle/types/vote.go |
Removed String methods and gopkg.in/yaml.v2 import. |
x/sudo/keeper/msg_server.go |
Modified String() method in Sudoers struct. |
x/sudo/types/state.go |
Removed String() method from Sudoers struct. |
x/tokenfactory/cli/cli_test.go x/tokenfactory/keeper/genesis.go x/tokenfactory/keeper/genesis_test.go x/tokenfactory/keeper/grpc_query_test.go x/tokenfactory/keeper/msg_server.go |
Various method call replacements and updates. |
x/tokenfactory/keeper/msg_server_test.go x/tokenfactory/keeper/store.go x/tokenfactory/keeper/store_test.go x/tokenfactory/keeper/wasm_test.go |
Changes involving String() to Denom() method calls. |
x/tokenfactory/types/state.go |
Renamed String() method to DenomStr() for TFDenom type. |
x/tokenfactory/types/state_test.go |
Replaced String() with PrettyString() in specific functions. |
CHANGELOG.md |
Added chore entry for removing proto stringer in PR #1874. |
🐇
A rabbit hopped through fields of code, Where stringers once had made their abode. With nimble paws and whiskers keen, It tidied up the codebase scene. Now messages are lean and clear, Thanks to our bunny engineer! 🐰
🌸
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.17%. Comparing base (
aeff126
) to head (19bac32
).
As per https://docs.cosmos.network/v0.50/build/migrations/upgrading#stringer, remove the stringer from the gogo proto.
For TD denoms, I had to create a pretty print for the "tf/contract_address/denom" logic.