NibiruChain / nibiru

Nibiru Chain: The breakthrough smart contract platform ushering in the next era of money. Nibiru powers an ecosystem of dApps including perps, RWAs, and more.
https://nibiru.fi
Apache License 2.0
183 stars 201 forks source link

feat(gosdk): migrate Go-sdk into the Nibiru blockchain repo. #1893

Closed Unique-Divine closed 4 months ago

Unique-Divine commented 4 months ago

Purpose / Abstract

  1. Exposes test utils for broadcasting transactions and querying using direct gRPC connections for easier testing. For example, the Ethereum JSON-RPC tests will be more direct using exported types rather than requiring us to use CLI commands to interact with the "eth" server.
  2. Makes it easier to import the Go SDK functionality, which currently uses NibiruChain/nibiru as a dependency anyway.
coderabbitai[bot] commented 4 months ago

Walkthrough

The recent update ushers in significant enhancements to the Nibiru blockchain repository, including refined .gitignore rules, integration of a new Go SDK, and various improvements across server and SDK files. These changes aim to streamline development and enhance interactions with the blockchain network.

Changes

Files Change Summary
.gitignore Updated to include coverage.html, temp*, txout.json, and vote.json, while excluding coverage.txt.
CHANGELOG.md Documented the migration of the Go SDK into the Nibiru blockchain repository.
app/server/start.go Removed a blank line after the openTraceWriter call.
app/server/util.go Commented out NewIndexTxCmd() with a TODO note for checking the indexer transaction command.
gosdk/clientctx.go,
gosdk/broadcast.go,
gosdk/export_test.go,
gosdk/gosdk.go,
gosdk/gosdk_test.go,
gosdk/grpc.go,
gosdk/keys.go,
gosdk/keys_test.go,
gosdk/netinfo.go,
gosdk/querier.go,
gosdk/rpc.go,
gosdk/sequence_test.go
Added various functionalities, tests, and structures to the Nibiru Go SDK for blockchain interaction.
justfile Updated gofumpt command to include gosdk and eth in the fmt target.

🐰✨ In the land of code, where changes bloom, A Go SDK now lights up the room. With tests and keys, the blockchain sings, As developers soar on innovation's wings. The .gitignore grows, the server refines, And Nibiru's future brightly shines. 🚀💻🌟

[!TIP]

New Features and Improvements ## Review Settings Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. ## AST-based Instructions CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the [documentation](https://docs.coderabbit.ai/guides/review-instructions#ast-based). ## Community-driven AST-based Rules We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the [ast-grep-essentials](https://github.com/coderabbitai/ast-grep-essentials) repository for more information. ## New Static Analysis Tools We are continually expanding our support for static analysis tools. We have added support for `biome`, `hadolint`, and `ast-grep`. Update the settings in your `.coderabbit.yaml` file or head over to the settings page to enable or disable the tools you want to use. ## Tone Settings Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples: - Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!" - Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!" - Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!" ## Revamped Settings Page We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to `.coderabbit.yaml` will be reflected in the settings page, and vice versa. ## Miscellaneous - Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the `enable_free_tier` setting. - Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (`local`) or the organization (`global`) level using the `knowledge_base` setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations. - High-level summary placement: You can now customize the location of the high-level summary in the PR description using the `high_level_summary_placeholder` setting (default `@coderabbitai summary`). - Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the `request_changes_workflow` setting.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 80.80808% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 67.37%. Comparing base (fa77747) to head (6701a1f).

:exclamation: Current head 6701a1f differs from pull request most recent head b37b6e5

Please upload reports for the commit b37b6e5 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1893 +/- ## ========================================== + Coverage 67.17% 67.37% +0.20% ========================================== Files 212 218 +6 Lines 13447 13641 +194 ========================================== + Hits 9033 9191 +158 - Misses 3768 3790 +22 - Partials 646 660 +14 ``` | [Files](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1893?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | Coverage Δ | | |---|---|---| | [gosdk/keys.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1893?src=pr&el=tree&filepath=gosdk%2Fkeys.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-Z29zZGsva2V5cy5nbw==) | `100.00% <100.00%> (ø)` | | | [gosdk/querier.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1893?src=pr&el=tree&filepath=gosdk%2Fquerier.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-Z29zZGsvcXVlcmllci5nbw==) | `100.00% <100.00%> (ø)` | | | [gosdk/rpc.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1893?src=pr&el=tree&filepath=gosdk%2Frpc.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-Z29zZGsvcnBjLmdv) | `100.00% <100.00%> (ø)` | | | [gosdk/grpc.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1893?src=pr&el=tree&filepath=gosdk%2Fgrpc.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-Z29zZGsvZ3JwYy5nbw==) | `89.47% <89.47%> (ø)` | | | [x/common/testutil/cli/network.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1893?src=pr&el=tree&filepath=x%2Fcommon%2Ftestutil%2Fcli%2Fnetwork.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9jb21tb24vdGVzdHV0aWwvY2xpL25ldHdvcmsuZ28=) | `77.41% <75.00%> (+0.25%)` | :arrow_up: | | [gosdk/gosdk.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1893?src=pr&el=tree&filepath=gosdk%2Fgosdk.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-Z29zZGsvZ29zZGsuZ28=) | `73.07% <73.07%> (ø)` | | | [gosdk/broadcast.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1893?src=pr&el=tree&filepath=gosdk%2Fbroadcast.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-Z29zZGsvYnJvYWRjYXN0Lmdv) | `74.35% <74.35%> (ø)` | |