search

NibiruChain / nibiru

Nibiru Chain: The breakthrough smart contract platform ushering in the next era of money. Nibiru powers an ecosystem of dApps including perps, RWAs, and more.
https://nibiru.fi
Apache License 2.0
179 stars 200 forks source link

feat(wasm)!: increase contract size limit to 3MB #1906

Closed k-yang closed 1 month ago

k-yang commented 1 month ago

Purpose / Abstract

Increases the contract size limit to 3MB (up from 800KB). I originally tried to set the config via compile time flag (-X github.com/CosmWasm/wasmd/x/wasm/types.MaxWasmSize=3145728) but got an error github.com/CosmWasm/wasmd/x/wasm/types.MaxWasmSize: cannot set with -X: not a var of type string (type:int). Seems like it's not possible to set an int variable with a compile time flag.

I took inspiration from Osmosis' overrideWasmVariables().

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent update increases the contract size limit to 3MB in the Nibiru EVM. This change involves adding a new function overrideWasmVariables in app.go to adjust the wasm size limitations, allowing for larger wasm files. This enhancement ensures that the contract size limit exceeds 2.5MB, addressing the requirements specified in issue #1905.

Changes

File(s) Change Summary
CHANGELOG.md Added a summary of the change, highlighting the increase in contract size limit.
app/app.go Introduced overrideWasmVariables function to adjust wasm size limitations.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant Nibiru EVM
    participant App

    User->>Nibiru EVM: Deploy contract (>2.5MB)
    Nibiru EVM->>App: Check wasm size
    App->>App: overrideWasmVariables()
    App->>Nibiru EVM: Allow deployment (size limit 3MB)
    Nibiru EVM->>User: Contract deployed successfully

Assessment against linked issues

Objective Addressed Explanation
Increase contract size limit to >2.5MB (#1905) ✅

Poem

In the land of code, a change did rise,
To let the contracts grow in size.
From two-point-five to three megabytes,
Now wasm files reach new heights.
With overrideWasmVariables in play,
Bigger contracts deploy without delay.
🎉🐇💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.14%. Comparing base (e7e708d) to head (9fa8b71).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1906 +/- ## ======================================= Coverage 62.13% 62.14% ======================================= Files 245 245 Lines 16006 16010 +4 ======================================= + Hits 9946 9950 +4 Misses 5323 5323 Partials 737 737 ``` | [Files](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1906?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | Coverage Δ | | |---|---|---| | [app/app.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1906?src=pr&el=tree&filepath=app%2Fapp.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2FwcC5nbw==) | `55.92% <100.00%> (+1.19%)` | :arrow_up: |