search

NibiruChain / nibiru

Nibiru Chain: The breakthrough smart contract platform ushering in the next era of money. Nibiru powers an ecosystem of dApps including perps, RWAs, and more.
https://nibiru.fi
Apache License 2.0
179 stars 200 forks source link

test(evm): grpc_query full coverage #1907

Closed onikonychev closed 1 month ago

onikonychev commented 1 month ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent updates to the NibiruChain/nibiru project primarily focus on enhancing test coverage and improving code quality within the Ethereum Virtual Machine (EVM) module. Key changes include the addition of comprehensive test functions for EVM queries and transactions, modifications to existing functions, and minor code cleanup across various files. These changes aim to ensure robust testing, better code maintainability, and improved functionality within the EVM-related components.

Changes

File Path Change Summary
CHANGELOG.md Added entry for PR #1907, detailing enhancements in test coverage for grpc_query related functionality in the EVM module.
x/evm/evmtest/eth.go Modified EthAddrToNibiruAddr function to change return type from sdk.AccAddress to []byte.
x/evm/keeper/grpc_query_test.go Added multiple new functions and test cases for EVM queries and transactions, enhancing testing capabilities.
x/evm/keeper/keeper_test.go Updated a comment for clarity.
x/evm/evmtest/tx.go Added new imports and functions for handling Nibi transfers, ERC-20 transfers, and Ethereum transaction generation/signing.
app/evmante_fees.go Removed unnecessary parentheses in a variable declaration.
gosdk/gosdk_test.go, x/tokenfactory/cli/cli_test.go Modified the declaration of SetupAllSuite and TearDownAllSuite interfaces within the TestSuite struct.

Sequence Diagram(s) (Beta)

Poem

In the land where code does thrive,
EVM tests now come alive.
Nibi transfers, ERC-20 too,
All are covered, through and through.
With cleaner code and functions bright,
NibiruChain shines in the night.
πŸ‡βœ¨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 1.58730% with 62 lines in your changes missing coverage. Please review.

Project coverage is 63.13%. Comparing base (ad173e9) to head (290c372). Report is 1 commits behind head on main.

:exclamation: Current head 290c372 differs from pull request most recent head f73cdc3

Please upload reports for the commit f73cdc3 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1907 +/- ## ========================================== + Coverage 62.34% 63.13% +0.78% ========================================== Files 245 245 Lines 15949 16011 +62 ========================================== + Hits 9944 10108 +164 + Misses 5269 5161 -108 - Partials 736 742 +6 ``` | [Files](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1907?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | Coverage Ξ” | | |---|---|---| | [x/evm/evmtest/eth.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1907?src=pr&el=tree&filepath=x%2Fevm%2Fevmtest%2Feth.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0vZXZtdGVzdC9ldGguZ28=) | `100.00% <100.00%> (ΓΈ)` | | | [x/evm/evmtest/tx.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1907?src=pr&el=tree&filepath=x%2Fevm%2Fevmtest%2Ftx.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0vZXZtdGVzdC90eC5nbw==) | `0.00% <0.00%> (ΓΈ)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1907/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain)