search

NibiruChain / nibiru

Nibiru Chain: The breakthrough smart contract platform ushering in the next era of money. Nibiru powers an ecosystem of dApps including perps, RWAs, and more.
https://nibiru.fi
Apache License 2.0
178 stars 208 forks source link

chore(evm): simplified config by removing old eth forks #1911

Closed onikonychev closed 1 month ago

onikonychev commented 1 month ago

Less code, less bugs

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent changes simplify Ethereum configuration handling by removing old Ethereum forks and related checks. The updates streamline the code by refactoring configuration access, removing deprecated fields, and ensuring consistent intrinsic gas calculations. These modifications enhance code readability and maintainability while ensuring the system remains up-to-date with current Ethereum standards.

Changes

Files Change Summary
CHANGELOG.md Simplified configuration by removing old Ethereum forks.
app/evmante_eth.go Removed chainCfg, ethCfg, and related checks; updated configuration reference.
app/evmante_sigverify.go Updated ethCfg retrieval method.
eth/rpc/backend/call_tx.go Modified cfg assignment method.
eth/rpc/backend/chain_info.go Simplified chain configuration retrieval.
eth/rpc/backend/chain_info_test.go Updated test case names to focus on enabled features.
proto/eth/evm/v1/evm.proto Deprecated chain_config field; removed ChainConfig message.
proto/eth/evm/v1/query.proto Simplified BaseFee RPC method description.
x/evm/chain_config.go Refactored EthereumConfig function; simplified block value initialization.
x/evm/chain_config_test.go Simplified TestChainConfigValidate function logic.
x/evm/evmtest/smart_contract_test.go Refactored Ethereum configuration access in tests.
x/evm/keeper/gas_fees.go Simplified intrinsic gas calculation logic.
x/evm/keeper/grpc_query.go Removed conditional check for traceConfig.Overrides.
x/evm/keeper/msg_server.go Simplified access list setup logic.
x/evm/keeper/vm_config.go Updated method call for Ethereum configuration retrieval.
x/evm/params.go Removed ChainConfig references and validation logic.
x/evm/statedb/statedb.go Reformatted PrepareAccessList method for readability.

Poem

In code's vast and intricate dance,
We simplified, gave it a chance.
Old forks now gone, the path is clear,
Ethereum's future, we hold dear.
With gas and fees, we set things right,
A streamlined flow, a coder's delight.
🌟✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.91%. Comparing base (957c7b2) to head (f6b4bc7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1911 +/- ## ========================================== - Coverage 63.13% 62.91% -0.22% ========================================== Files 245 245 Lines 16011 15900 -111 ========================================== - Hits 10108 10003 -105 + Misses 5161 5157 -4 + Partials 742 740 -2 ``` | [Files](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1911?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | Coverage Δ | | |---|---|---| | [eth/rpc/backend/chain\_info.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1911?src=pr&el=tree&filepath=eth%2Frpc%2Fbackend%2Fchain_info.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-ZXRoL3JwYy9iYWNrZW5kL2NoYWluX2luZm8uZ28=) | `81.98% <100.00%> (ø)` | | | [x/evm/keeper/grpc\_query.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1911?src=pr&el=tree&filepath=x%2Fevm%2Fkeeper%2Fgrpc_query.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0va2VlcGVyL2dycGNfcXVlcnkuZ28=) | `82.44% <ø> (+0.48%)` | :arrow_up: | | [x/evm/keeper/msg\_server.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1911?src=pr&el=tree&filepath=x%2Fevm%2Fkeeper%2Fmsg_server.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0va2VlcGVyL21zZ19zZXJ2ZXIuZ28=) | `61.27% <100.00%> (-0.17%)` | :arrow_down: | | [x/evm/keeper/vm\_config.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1911?src=pr&el=tree&filepath=x%2Fevm%2Fkeeper%2Fvm_config.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0va2VlcGVyL3ZtX2NvbmZpZy5nbw==) | `81.39% <100.00%> (ø)` | | | [x/evm/params.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1911?src=pr&el=tree&filepath=x%2Fevm%2Fparams.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0vcGFyYW1zLmdv) | `30.92% <ø> (-1.15%)` | :arrow_down: | | [x/evm/statedb/statedb.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1911?src=pr&el=tree&filepath=x%2Fevm%2Fstatedb%2Fstatedb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0vc3RhdGVkYi9zdGF0ZWRiLmdv) | `95.77% <100.00%> (ø)` | | | [app/evmante\_eth.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1911?src=pr&el=tree&filepath=app%2Fevmante_eth.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2V2bWFudGVfZXRoLmdv) | `41.81% <50.00%> (-1.72%)` | :arrow_down: | | [app/evmante\_sigverify.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1911?src=pr&el=tree&filepath=app%2Fevmante_sigverify.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2V2bWFudGVfc2lndmVyaWZ5Lmdv) | `0.00% <0.00%> (ø)` | | | [eth/rpc/backend/call\_tx.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1911?src=pr&el=tree&filepath=eth%2Frpc%2Fbackend%2Fcall_tx.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-ZXRoL3JwYy9iYWNrZW5kL2NhbGxfdHguZ28=) | `61.18% <0.00%> (ø)` | | | [x/evm/chain\_config.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1911?src=pr&el=tree&filepath=x%2Fevm%2Fchain_config.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0vY2hhaW5fY29uZmlnLmdv) | `93.10% <95.45%> (-6.90%)` | :arrow_down: | | ... and [1 more](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1911?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | |