search

NibiruChain / nibiru

Nibiru Chain: The breakthrough smart contract platform ushering in the next era of money. Nibiru powers an ecosystem of dApps including perps, RWAs, and more.
https://nibiru.fi
Apache License 2.0
178 stars 208 forks source link

test(evm): unit tests for evm_ante #1912

Closed onikonychev closed 4 weeks ago

onikonychev commented 1 month ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent changes introduce a variety of enhancements and new features focused on Ethereum transaction handling within the Cosmos SDK. These include restructuring error messages for clarity, adding new decorators for event emission, fee checking, and gas consumption, and implementing comprehensive test suites to validate these functionalities. The updates aim to improve the robustness and readability of the Ethereum Virtual Machine (EVM) integration in the application.

Changes

File(s) Change Summary
CHANGELOG.md Added unit tests for evm_ante_sigverify.
app/evmante_sigverify.go Restructured error messages for invalid message types and rejected unprotected Ethereum transactions.
app/evmante_emit_event.go Introduced EthEmitEventDecorator for handling event emissions in Ethereum transactions.
app/evmante_setup_ctx.go Refactored transaction validation and event emission logic, removed unused imports and structs.
app/evmante_setup_ctx_test.go Added test case TestEthSetupContextDecorator.
app/evmante_validate_basic.go Introduced EthValidateBasicDecorator for basic validation of Ethereum transactions.
app/evmante_emit_event_test.go Added test suite for EthEmitEventDecorator.
app/evmante_gas_wanted_test.go Added test suite for GasWantedDecorator.
app/evmante_validate_basic_test.go Added test cases for Ethereum transaction validation.
x/evm/tx.go Added a comment to the EvmTxArgs struct definition.
app/evmante_fee_checker.go Reformatted error messages and improved readability.
app/evmante_fee_checker_test.go Added test suite for NewDynamicFeeChecker.
app/evmante_fees.go Reformatted error message string for readability.
app/evmante_fees_test.go Added test suite for EthMinGasPriceDecorator.
app/evmante_can_transfer.go Introduced CanTransferDecorator for transfer validation in Ethereum transactions.
app/evmante_can_transfer_test.go Added test suite for CanTransferDecorator.
app/evmante_gas_consume.go Introduced functionality for gas validation and fee management in Ethereum transactions.
app/evmante_gas_consume_test.go Added test suite for gas consumption scenarios.
app/evmante_handler_test.go Added test cases for AnteHandler in EVM context.
app/evmante_increment_sender_seq.go Introduced AnteDecEthIncrementSenderSequence for handling sender sequence increment.
app/evmante_increment_sender_seq_test.go Added test suite for incrementing sender sequence in Ethereum transactions.
app/evmante_reject_msgs_test.go Added test suite for preventing Ethereum transaction messages.
app/evmante_verify_eth_acc_test.go Added functions happyTransfertTx and nonEvmMsgTx, removed commented-out test function.
contrib/make/test.mk Added -v flag to go test command in test-coverage-integration target.

Poem

In lines of code, where changes flow,
Ethereum's strength begins to grow.
With decorators new and tests so bright,
We ensure transactions are handled right.
From gas to fees, each step refined,
In Cosmos, Ethereum's stars aligned.
🐇✨🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 77.91045% with 74 lines in your changes missing coverage. Please review.

Project coverage is 64.76%. Comparing base (42a8b65) to head (8a50e0e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1912 +/- ## ========================================== + Coverage 63.05% 64.76% +1.71% ========================================== Files 245 250 +5 Lines 15871 15963 +92 ========================================== + Hits 10007 10339 +332 + Misses 5122 4871 -251 - Partials 742 753 +11 ``` | [Files](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | Coverage Δ | | |---|---|---| | [app/evmante\_emit\_event.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912?src=pr&el=tree&filepath=app%2Fevmante_emit_event.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2V2bWFudGVfZW1pdF9ldmVudC5nbw==) | `100.00% <100.00%> (ø)` | | | [app/evmante\_fees.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912?src=pr&el=tree&filepath=app%2Fevmante_fees.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2V2bWFudGVfZmVlcy5nbw==) | `88.88% <100.00%> (+88.88%)` | :arrow_up: | | [app/evmante\_gas\_wanted.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912?src=pr&el=tree&filepath=app%2Fevmante_gas_wanted.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2V2bWFudGVfZ2FzX3dhbnRlZC5nbw==) | `100.00% <ø> (ø)` | | | [app/evmante\_sigverify.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912?src=pr&el=tree&filepath=app%2Fevmante_sigverify.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2V2bWFudGVfc2lndmVyaWZ5Lmdv) | `100.00% <100.00%> (+100.00%)` | :arrow_up: | | [x/evm/tx.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912?src=pr&el=tree&filepath=x%2Fevm%2Ftx.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0vdHguZ28=) | `85.02% <ø> (ø)` | | | [app/evmante\_setup\_ctx.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912?src=pr&el=tree&filepath=app%2Fevmante_setup_ctx.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2V2bWFudGVfc2V0dXBfY3R4Lmdv) | `66.66% <0.00%> (+66.66%)` | :arrow_up: | | [app/evmante\_verify\_eth\_acc.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912?src=pr&el=tree&filepath=app%2Fevmante_verify_eth_acc.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2V2bWFudGVfdmVyaWZ5X2V0aF9hY2MuZ28=) | `85.71% <85.71%> (ø)` | | | [app/evmante\_increment\_sender\_seq.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912?src=pr&el=tree&filepath=app%2Fevmante_increment_sender_seq.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2V2bWFudGVfaW5jcmVtZW50X3NlbmRlcl9zZXEuZ28=) | `70.00% <70.00%> (ø)` | | | [app/evmante\_can\_transfer.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912?src=pr&el=tree&filepath=app%2Fevmante_can_transfer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2V2bWFudGVfY2FuX3RyYW5zZmVyLmdv) | `78.84% <78.84%> (ø)` | | | [app/evmante\_validate\_basic.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912?src=pr&el=tree&filepath=app%2Fevmante_validate_basic.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-YXBwL2V2bWFudGVfdmFsaWRhdGVfYmFzaWMuZ28=) | `88.23% <88.23%> (ø)` | | | ... and [2 more](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1912/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain)