NibiruChain / nibiru

Nibiru Chain: The breakthrough smart contract platform ushering in the next era of money. Nibiru powers an ecosystem of dApps including perps, RWAs, and more.
https://nibiru.fi
Apache License 2.0
178 stars 208 forks source link

feat(evm): tx for creating fun token from coin #1946

Closed onikonychev closed 2 days ago

onikonychev commented 1 week ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

The submitted changes introduce a new feature to the NibiruChain/nibiru project: the ability to register an existing Cosmos coin as an EVM ERC-20 fungible token, known as a "fun token." This feature includes modifications to .proto files, new methods in the Keeper struct, and associated test cases to ensure functionality and robustness.

Changes

File(s) Summary
CHANGELOG.md Added a feature for creating a fun token from a coin in the EVM module.
proto/eth/evm/v1/events.proto Added EventCreateFunTokenFromCoin message with fields denom, contract_address, and creator.
proto/eth/evm/v1/tx.proto Added CreateFunTokenFromCoin RPC, messages MsgCreateFunTokenFromCoin and MsgCreateFunTokenFromCoinResponse.
x/evm/keeper/funtoken_state.go Renamed variable funtoken to funToken in SafeInsert method.
x/evm/keeper/msg_fun_token.go Introduced method CreateFunTokenFromCoin in Keeper struct to register Cosmos coin as fun token.
x/evm/keeper/msg_fun_token_test.go Added TestMsgCreateFunTokenFromCoin in the keeper_test package.
x/evm/msg.go Integrated MsgCreateFunTokenFromCoin, its ValidateBasic, and GetSigners methods.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Client
    participant CosmosApp
    participant EVMModule
    participant Keeper

    User->>Client: Initiate CreateFunTokenFromCoin Request
    Client->>CosmosApp: Send MsgCreateFunTokenFromCoin
    CosmosApp->>EVMModule: Forward MsgCreateFunTokenFromCoin
    EVMModule->>Keeper: Call CreateFunTokenFromCoin Method
    Keeper-->>EVMModule: Return MsgCreateFunTokenFromCoinResponse
    EVMModule-->>CosmosApp: Response with new_contract_address
    CosmosApp-->>Client: Return new_contract_address
    Client-->>User: Display new_contract_address

Possibly related issues

Poem

Amidst the chains that intertwine,
A coin transforms by design.
With magic code and tokens spun,
Cosmos meets EVM, the fun's begun.
In bytes and blocks, they come alive,
A rabbit's joy, the chains now thrive.
🌟🚀


[!TIP]

Early access features: enabled We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 64.80%. Comparing base (822d838) to head (202a3bd).

:exclamation: Current head 202a3bd differs from pull request most recent head cd1ec0a

Please upload reports for the commit cd1ec0a to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1946 +/- ## ========================================== - Coverage 64.83% 64.80% -0.03% ========================================== Files 253 254 +1 Lines 16065 16092 +27 ========================================== + Hits 10416 10429 +13 - Misses 4892 4904 +12 - Partials 757 759 +2 ``` | [Files](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1946?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain) | Coverage Δ | | |---|---|---| | [x/evm/keeper/funtoken\_state.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1946?src=pr&el=tree&filepath=x%2Fevm%2Fkeeper%2Ffuntoken_state.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0va2VlcGVyL2Z1bnRva2VuX3N0YXRlLmdv) | `92.00% <66.66%> (ø)` | | | [x/evm/keeper/msg\_fun\_token.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1946?src=pr&el=tree&filepath=x%2Fevm%2Fkeeper%2Fmsg_fun_token.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0va2VlcGVyL21zZ19mdW5fdG9rZW4uZ28=) | `76.47% <76.47%> (ø)` | | | [x/evm/msg.go](https://app.codecov.io/gh/NibiruChain/nibiru/pull/1946?src=pr&el=tree&filepath=x%2Fevm%2Fmsg.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NibiruChain#diff-eC9ldm0vbXNnLmdv) | `71.42% <0.00%> (-3.14%)` | :arrow_down: |