Closed Unique-Divine closed 2 months ago
[!WARNING]
Review failed
The pull request is closed.
This update improves the cleanup process for validator nodes in the testnetwork
package, ensuring synchronous cleanup using a wait group and concurrent goroutines for better coordination. Additionally, various files have been refactored for clarity, and package imports have been reorganized or renamed to testnetwork
.
Files | Change Summary |
---|---|
x/common/testutil/cli/network.go , x/common/testutil/testnetwork/logger.go , network.go |
Enhanced cleanup process using wait groups and concurrent goroutines, introduced stopValidatorNode and ValidatorsStopped checks. |
CHANGELOG.md |
Mentioned the addition of a test to ensure consistent CI runs with improved cleanup procedures. |
x/common/testutil/cli/util.go |
Updated startInProcess to assign a logger to val.tmNode.Logger . |
x/evm/keeper/grpc_query_test.go , x/common/testutil/testnetwork/query.go |
Added the strings package import and modified TestTraceTx and TestTraceBlock functions for better comparison of responses. |
app/wasmext/wasm_cli_test/cli_test.go , eth/rpc/rpcapi/eth_api_test.go |
Renamed imports from testutilcli to testnetwork for better organization in CLI test commands and network utilities. |
gosdk/export_test.go , gosdk/gosdk_test.go , gosdk/sequence_test.go |
Renamed cli.Config , cli.Network , and cli.Validator to testnetwork.Config , testnetwork.Network , and testnetwork.Validator . |
x/tokenfactory/cli/cli_test.go |
Updated import references related to testutilcli to testnetwork . |
x/common/testutil/testnetwork/... encompassing doc.go , logger.go , network.go , etc. |
Renamed package from cli to testnetwork , removed unnecessary imports and fields, and reorganized structures for better clarity. |
Objective (Issues) | Addressed | Explanation |
---|---|---|
Perform synchronous cleanup of nodes on cleanup (#1955) | ✅ | |
Use concurrent goroutines for improved cleanup coordination | ✅ | |
Refactor code for better clarity and organization | ✅ |
In the realm of code, where tests abide, A network cleaned with enhanced pride, Goroutines dance, in harmony they flew, Ensuring validators bid their due. Under
testnetwork
, changes sleek, Our cleanup strong, our structure peak.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 81.17647%
with 16 lines
in your changes missing coverage. Please review.
Project coverage is 65.65%. Comparing base (
76bdaaa
) to head (c93be71
).
Purpose / Abstract
Summary by CodeRabbit
Refactor
testutilcli
totestnetwork
across multiple files for better organization and clarity.Cleanup
method to ensure services stop gracefully before cleanup.New Features
Bug Fixes
Tests